From: Kees Cook <keescook@chromium.org>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: shuah@kernel.org, davidgow@google.com, arnd@arndb.de,
rafael@kernel.org, jic23@kernel.org, lars@metafoo.de,
ulf.hansson@linaro.org, andreas.noever@gmail.com,
michael.jamet@intel.com, mika.westerberg@linux.intel.com,
YehezkelShB@gmail.com, masahiroy@kernel.org,
michal.lkml@markovi.net, ndesaulniers@google.com,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-usb@vger.kernel.org,
linux-hardening@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v1 2/6] iio/test-format: build kunit tests without structleak plugin
Date: Fri, 17 Sep 2021 08:54:44 -0700 [thread overview]
Message-ID: <202109170851.4485B94148@keescook> (raw)
In-Reply-To: <20210917061104.2680133-3-brendanhiggins@google.com>
On Thu, Sep 16, 2021 at 11:11:00PM -0700, Brendan Higgins wrote:
> The structleak plugin causes the stack frame size to grow immensely when
> used with KUnit:
>
> ../drivers/iio/test/iio-test-format.c: In function ‘iio_test_iio_format_value_fixedpoint’:
> ../drivers/iio/test/iio-test-format.c:98:1: warning: the frame size of 2336 bytes is larger than 2048 bytes [-Wframe-larger-than=]
>
> Turn it off in this file.
Given that these are all for KUnit tests, is it possible there are going
to be other CONFIGs that will interact poorly (e.g. KASAN)? Maybe there
needs to be a small level of indirection with something like:
DISABLE_UNDER_KUNIT := $(DISABLE_STRUCTLEAK_PLUGIN)
export DISABLE_UNDER_KUNIT
then all of these become:
+CFLAGS_iio-test-format.o += $(DISABLE_UNDER_KUNIT)
Either way, I think these are fine to add.
Reviewed-by: Kees Cook <keescook@chromium.org>
>
> Co-developed-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---
> drivers/iio/test/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/test/Makefile b/drivers/iio/test/Makefile
> index f1099b4953014..467519a2027e5 100644
> --- a/drivers/iio/test/Makefile
> +++ b/drivers/iio/test/Makefile
> @@ -5,3 +5,4 @@
>
> # Keep in alphabetical order
> obj-$(CONFIG_IIO_TEST_FORMAT) += iio-test-format.o
> +CFLAGS_iio-test-format.o += $(DISABLE_STRUCTLEAK_PLUGIN)
> --
> 2.33.0.464.g1972c5931b-goog
>
--
Kees Cook
next prev parent reply other threads:[~2021-09-17 15:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 6:10 [PATCH v1 0/6] kunit: build kunit tests without structleak plugin Brendan Higgins
2021-09-17 6:10 ` [PATCH v1 1/6] gcc-plugins/structleak: add makefile var for disabling structleak Brendan Higgins
2021-09-17 15:48 ` Kees Cook
2021-09-29 20:25 ` Brendan Higgins
2021-09-17 6:11 ` [PATCH v1 2/6] iio/test-format: build kunit tests without structleak plugin Brendan Higgins
2021-09-17 15:54 ` Kees Cook [this message]
2021-09-29 20:50 ` Brendan Higgins
2021-09-18 15:58 ` Jonathan Cameron
2021-09-17 6:11 ` [PATCH v1 3/6] device property: " Brendan Higgins
2021-09-17 15:54 ` Kees Cook
2021-09-17 6:11 ` [PATCH v1 4/6] thunderbolt: " Brendan Higgins
2021-09-17 10:16 ` Mika Westerberg
2021-09-17 15:55 ` Kees Cook
2021-09-17 6:11 ` [PATCH v1 5/6] mmc: sdhci-of-aspeed: " Brendan Higgins
2021-09-17 15:56 ` Kees Cook
2021-09-17 18:40 ` Linus Torvalds
2021-09-29 20:59 ` Brendan Higgins
2021-09-17 6:11 ` [PATCH v1 6/6] bitfield: " Brendan Higgins
2021-09-17 7:22 ` Arnd Bergmann
2021-09-17 15:57 ` Kees Cook
2021-09-29 21:04 ` Brendan Higgins
2021-09-17 7:38 ` [PATCH v1 0/6] kunit: " Arnd Bergmann
2021-09-29 20:46 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202109170851.4485B94148@keescook \
--to=keescook@chromium.org \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=arnd@arndb.de \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=lars@metafoo.de \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michael.jamet@intel.com \
--cc=michal.lkml@markovi.net \
--cc=mika.westerberg@linux.intel.com \
--cc=ndesaulniers@google.com \
--cc=rafael@kernel.org \
--cc=shuah@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).