linux-hardening.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Kees Cook <keescook@chromium.org>
Cc: Miguel Ojeda <ojeda@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Nathan Chancellor <nathan@kernel.org>,
	llvm@lists.linux.dev, George Burgess IV <gbiv@google.com>,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: [PATCH v6 3/4] Compiler Attributes: Add __diagnose_as for Clang
Date: Thu,  3 Feb 2022 09:33:06 -0800	[thread overview]
Message-ID: <20220203173307.1033257-4-keescook@chromium.org> (raw)
In-Reply-To: <20220203173307.1033257-1-keescook@chromium.org>

Clang will perform various compile-time diagnostics on uses of various
functions (e.g. simple bounds-checking on strcpy(), etc). These
diagnostics can be assigned to other functions (for example, new
implementations of the string functions under CONFIG_FORTIFY_SOURCE)
using the "diagnose_as_builtin" attribute. This allows those functions
to retain their compile-time diagnostic warnings.

Cc: Miguel Ojeda <ojeda@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: llvm@lists.linux.dev
Signed-off-by: Kees Cook <keescook@chromium.org>
---
 include/linux/compiler_attributes.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h
index dc3bf2a6e1c9..df9c7e5e8818 100644
--- a/include/linux/compiler_attributes.h
+++ b/include/linux/compiler_attributes.h
@@ -100,6 +100,19 @@
 # define __copy(symbol)
 #endif
 
+/*
+ * Optional: not supported by gcc
+ * Optional: only supported since clang >= 14.0
+ * Optional: not supported by icc
+ *
+ * clang: https://clang.llvm.org/docs/AttributeReference.html#diagnose_as_builtin
+ */
+#if __has_attribute(__diagnose_as_builtin__)
+# define __diagnose_as(builtin...)	__attribute__((__diagnose_as_builtin__(builtin)))
+#else
+# define __diagnose_as(builtin...)
+#endif
+
 /*
  * Don't. Just don't. See commit 771c035372a0 ("deprecate the '__deprecated'
  * attribute warnings entirely and for good") for more information.
-- 
2.30.2


  parent reply	other threads:[~2022-02-03 17:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-03 17:33 [PATCH v6 0/4] fortify: Add Clang support Kees Cook
2022-02-03 17:33 ` [PATCH v6 1/4] Compiler Attributes: Add __pass_object_size for Clang Kees Cook
2022-02-03 20:18   ` Nick Desaulniers
2022-02-03 20:58     ` Kees Cook
2022-02-03 22:01       ` Nick Desaulniers
2022-02-04  0:29         ` Kees Cook
2022-02-03 17:33 ` [PATCH v6 2/4] Compiler Attributes: Add __overloadable " Kees Cook
2022-02-03 20:26   ` Nick Desaulniers
2022-02-03 21:04     ` Kees Cook
2022-02-03 22:11       ` Nick Desaulniers
2022-02-04  0:26         ` Kees Cook
2022-02-04  0:58           ` Nick Desaulniers
2022-02-04  1:07       ` Miguel Ojeda
2022-02-03 17:33 ` Kees Cook [this message]
2022-02-03 20:28   ` [PATCH v6 3/4] Compiler Attributes: Add __diagnose_as " Nick Desaulniers
2022-02-03 17:33 ` [PATCH v6 4/4] fortify: Add Clang support Kees Cook
2022-02-03 20:37   ` Nick Desaulniers
2022-02-03 21:26     ` Kees Cook
2022-02-03 17:47 ` [PATCH v6 0/4] " Miguel Ojeda
2022-02-03 19:57   ` Kees Cook
2022-02-03 21:12     ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220203173307.1033257-4-keescook@chromium.org \
    --to=keescook@chromium.org \
    --cc=gbiv@google.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=ojeda@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).