archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <>
To: "Gustavo A. R. Silva" <>
Cc: Ariel Elior <>,
	Sudarsana Kalluru <>,
	Manish Chopra <>,
	"David S. Miller" <>,,,
Subject: Re: [PATCH][next] bnx2x: Replace one-element array with flexible-array member
Date: Fri, 4 Feb 2022 19:38:27 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20220204232144.GA442861@embeddedor>

On Fri, 4 Feb 2022 17:21:44 -0600 Gustavo A. R. Silva wrote:
> There is a regular need in the kernel to provide a way to declare having
> a dynamically sized set of trailing elements in a structure. Kernel code
> should always use “flexible array members”[1] for these cases. The older
> style of one-element or zero-length arrays should no longer be used[2].
> This helps with the ongoing efforts to globally enable -Warray-bounds
> and get us closer to being able to tighten the FORTIFY_SOURCE routines
> on memcpy().
> This issue was found with the help of Coccinelle and audited and fixed,
> manually.
> [1]
> [2]
> Link:
> Signed-off-by: Gustavo A. R. Silva <>

Would be useful to include the analysis confirming the change is safe
in this case, beyond the boiler plate commit message.

Reviewed-by: Jakub Kicinski <>

      reply	other threads:[~2022-02-05  3:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04 23:21 [PATCH][next] bnx2x: Replace one-element array with flexible-array member Gustavo A. R. Silva
2022-02-05  3:38 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).