From: Kees Cook <keescook@chromium.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alexander Popov <alex.popov@linux.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH 2/3] gcc-plugins/stackleak: Exactly match strings instead of prefixes
Date: Sun, 6 Feb 2022 10:49:15 -0800 [thread overview]
Message-ID: <202202061046.040D6A0A0@keescook> (raw)
In-Reply-To: <CAHk-=wg5oaiJty+pCLd7aS3c-86=JDvF_vuaUvyq+Yo6+cKhyg@mail.gmail.com>
On Sun, Feb 06, 2022 at 10:34:11AM -0800, Linus Torvalds wrote:
> On Sun, Feb 6, 2022 at 9:45 AM Kees Cook <keescook@chromium.org> wrote:
> >
> > + return !strncmp(TREE_STRING_POINTER(node), string, length);
>
> Why is this "strncmp()"? That makes no sense when you've just checked
> the exact lengths of both sides.
>
> You're not comparing strings any more, you've already checked the end
> of the string - you are comparing memory contents.
>
> So make it just do a "memcmp()".
Yeah, good point. I'll change this for v2, pending more feedback.
> > +#define STRING_EQUAL(node, str) string_equal(node, str, strlen(str))
>
> .. and please change this name too, since it's not comparing two
> strings. The first argument is something else entirely.
>
> It's checking the node value of a section, give it some name related to that.
Technically, yes. The naming bikeshed here is odd since it's called
"STRING" by gcc internals, and it *might* be a "C string", etc etc. I'll
rename it...
> I do also get the feeling that the nodes should actually be checked to
> be a STRING_CST rather than these blind TREE_VALUE() following things,
> but I don't really know the rules for gcc plugin internals very well -
> or at all, really.
I'll double-check this, but if it's not a STRING_CST something else has
gone very wrong already. But I'm a fan of robustness, so sure. :)
-Kees
--
Kees Cook
next prev parent reply other threads:[~2022-02-06 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 17:45 [PATCH 0/3] gcc-plugins/stackleak: Ignore .noinstr.text and .entry.text Kees Cook
2022-02-06 17:45 ` [PATCH 1/3] gcc-plugins/stackleak: Provide verbose mode Kees Cook
2022-02-06 17:45 ` [PATCH 2/3] gcc-plugins/stackleak: Exactly match strings instead of prefixes Kees Cook
2022-02-06 18:34 ` Linus Torvalds
2022-02-06 18:49 ` Kees Cook [this message]
2022-02-06 17:45 ` [PATCH 3/3] gcc-plugins/stackleak: Ignore .noinstr.text and .entry.text Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202202061046.040D6A0A0@keescook \
--to=keescook@chromium.org \
--cc=alex.popov@linux.com \
--cc=bp@alien8.de \
--cc=jpoimboe@redhat.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).