archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <>
To: "Gustavo A. R. Silva" <>
Cc: Greg Kroah-Hartman <>,,,
Subject: Re: [PATCH][next] staging: wlan-ng: Replace one-element arrays with flexible-array members
Date: Mon, 7 Feb 2022 10:33:50 +0300	[thread overview]
Message-ID: <20220207073350.GB1951@kadam> (raw)
In-Reply-To: <20220204233015.GA454979@embeddedor>

On Fri, Feb 04, 2022 at 05:30:15PM -0600, Gustavo A. R. Silva wrote:
> There is a regular need in the kernel to provide a way to declare having
> a dynamically sized set of trailing elements in a structure. Kernel code
> should always use “flexible array members”[1] for these cases. The older
> style of one-element or zero-length arrays should no longer be used[2].
> This helps with the ongoing efforts to globally enable -Warray-bounds
> and get us closer to being able to tighten the FORTIFY_SOURCE routines
> on memcpy().
> This issue was found with the help of Coccinelle and audited and fixed,
> manually.

How are you auditing this manually?  I have to re-audit it manually
myself as a reviewer and I'm find it tricky.

>  /*-- IBSS Parameter Set ---------------------------*/
> @@ -288,7 +288,7 @@ struct wlan_ie_ibss_parms {
>  struct wlan_ie_challenge {
>  	u8 eid;
>  	u8 len;
> -	u8 challenge[1];
> +	u8 challenge[];
>  } __packed;

This is dead code.  It would have been better to just delete that.  I
have a lot of experience at reviewing "Delete Dead Code" patches.

dan carpenter

      reply	other threads:[~2022-02-07  7:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04 23:30 [PATCH][next] staging: wlan-ng: Replace one-element arrays with flexible-array members Gustavo A. R. Silva
2022-02-07  7:33 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220207073350.GB1951@kadam \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).