From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 107DAC433F5 for ; Wed, 16 Feb 2022 20:35:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232191AbiBPUfi (ORCPT ); Wed, 16 Feb 2022 15:35:38 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:55404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232226AbiBPUfh (ORCPT ); Wed, 16 Feb 2022 15:35:37 -0500 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A6B92A417D for ; Wed, 16 Feb 2022 12:35:25 -0800 (PST) Received: by mail-pl1-x631.google.com with SMTP id c3so2894025pls.5 for ; Wed, 16 Feb 2022 12:35:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=3ql2gW0+Kw0ifh/Z8dAvBHWaqCHWEKHJC6WLG6hOvvU=; b=Ipb9XZivi/4A7bTkcfycdDfQ7GITOkpq0218108fQ32mq6OVDT5GAUaR/x2WddkZno Q20yVJVDuJTAuooetBmhYlgagPu9Gs3NAHuwSJGAJIl4bY/98e3+MdRVnVVD3syovpSw zdQcmjZ3NR7i2As96r400jjWmfwMS3lVScjrY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=3ql2gW0+Kw0ifh/Z8dAvBHWaqCHWEKHJC6WLG6hOvvU=; b=W/W+wQrH3ClfQZgjkJowj7xCcU8X9N76tQf6BMRS6TEeIFQqE6/SOca+FoC/yNDhCo mFa3Nd3kMXYQNc1lMwb8kSbq+iaw967WHeCt40uHO4o+Sv9LfTxaYA8oRi9BjQtFWkq/ QQdi9tsfmycbkJd5kTvwtzk6QzJUxu6JCBHaBOB0BOnqgyVPB8+nIQReakpvlImJ6hNu aAWWzcF1FEih5sSRRBnis4rBMnpyNkKRUodgBKY5FKxAE0bdOpykIOHH+qA9UtzpaYUq uIPQ+UytuM4jAjz7fI2Co2U/P/NLhXUhinShwA0+wfJF80Yq0j9xYoV1hRcuJjisssOs 0WhA== X-Gm-Message-State: AOAM531pP3LHPSDhaD6ZHDwaN3XsigJpL7xNWePea+sMSTZpK5SCl/kh Zxnf1gsSaHg5zJH4urG7Gzyzuw== X-Google-Smtp-Source: ABdhPJyFwMuDz1hEGZc7wO6ulmt0RPObdJ54PcQrbFHa5HUawv1Wc7Oi4dhYMbBcBQavRZUBb5r+LA== X-Received: by 2002:a17:902:82cc:b0:14e:d3e7:aaf2 with SMTP id u12-20020a17090282cc00b0014ed3e7aaf2mr3986109plz.66.1645043724576; Wed, 16 Feb 2022 12:35:24 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u2sm47618111pfk.15.2022.02.16.12.35.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 12:35:24 -0800 (PST) Date: Wed, 16 Feb 2022 12:35:22 -0800 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Luca Coelho , Kalle Valo , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] iwlwifi: mei: Replace zero-length array with flexible-array member Message-ID: <202202161235.F3A134A9@keescook> References: <20220216195030.GA904170@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220216195030.GA904170@embeddedor> Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Wed, Feb 16, 2022 at 01:50:30PM -0600, Gustavo A. R. Silva wrote: > There is a regular need in the kernel to provide a way to declare > having a dynamically sized set of trailing elements in a structure. > Kernel code should always use “flexible array members”[1] for these > cases. The older style of one-element or zero-length arrays should > no longer be used[2]. > > [1] https://en.wikipedia.org/wiki/Flexible_array_member > [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays > > Link: https://github.com/KSPP/linux/issues/78 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook