From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A703FC433F5 for ; Wed, 9 Mar 2022 17:18:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237164AbiCIRTe (ORCPT ); Wed, 9 Mar 2022 12:19:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237013AbiCIRTN (ORCPT ); Wed, 9 Mar 2022 12:19:13 -0500 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90F0EBE1E7 for ; Wed, 9 Mar 2022 09:17:32 -0800 (PST) Received: by mail-pf1-x433.google.com with SMTP id z16so2898772pfh.3 for ; Wed, 09 Mar 2022 09:17:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WeI6/9C1BCTGBKT+PvqLfTEaKntfc/ed6405/bCzY/w=; b=WDfWjEYckw/zTayapSSYfsRn64vQBqxp7Z9KMMkfujfBKUpKOHI8XIHGLayFZN4H2b u0u1AgWKPSDhByMnD5ntwL4Zs0Q77Drden/IjHQYanPve8puiSrPE2dDhQNRe3eWpmpZ tRmPU7DNz9Taggr1RjPonwqTWgEnaruaVIYSE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WeI6/9C1BCTGBKT+PvqLfTEaKntfc/ed6405/bCzY/w=; b=vkpEHzdjIDYXwwpNLR73pi+t+3DyJG+P6I2c3nKqJqjjyT4svdNvErsS4U0YRQ0N94 PxYSlNZeNHEJcDyqLB6jcB4qX1TD4Gk0PAyQXiionX64E7MXu0dZp0J5LeSrvEZdBCSU eWlgRljCYaq+IBfqv01UOyv7m1RgKR1Yn9gPqZM9WPA+6faRcsDjSEQHrsZL/dXGcb11 3idoM0awiTk47R9Xl1O0oppbstECoIyjkfQucKSa8iuCZC0hVV9Wmbn2dBUCUl+gRzsq pBOiajVMxHaxmZvETsV6j1XrvinKhSPq1690aqZuNqu7i5YFw05amy2pt2KL5wr2n7Nk 5mqQ== X-Gm-Message-State: AOAM533APsq8FvPEMu6sjkhFN1klo5uxsoNRqWQMFCUqKIO5XJ6b8OO2 g5pxe/17FschhH5lc8leCnDtOA== X-Google-Smtp-Source: ABdhPJyXk5M0FslPX7mQv4MfQEiZWkG1072olU1PS3FqjAEjICXjju+odpKPfrx+08nAfrdTgndITQ== X-Received: by 2002:a63:1554:0:b0:363:794c:9e31 with SMTP id 20-20020a631554000000b00363794c9e31mr628489pgv.66.1646846252021; Wed, 09 Mar 2022 09:17:32 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t6-20020a63b246000000b0038085c0a9d7sm2818271pgo.49.2022.03.09.09.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 09:17:31 -0800 (PST) Date: Wed, 9 Mar 2022 09:17:30 -0800 From: Kees Cook To: "Martin K. Petersen" Cc: Sreekanth Reddy , Sathya Prakash , Suganath Prabu Subramani , "James E.J. Bottomley" , linux-hardening@vger.kernel.org, linux-scsi , Linux Kernel Mailing List , PDL-MPT-FUSIONLINUX Subject: Re: [PATCH] scsi: mpt3sas: Convert to flexible arrays Message-ID: <202203090913.ED0241BEC@keescook> References: <20220201223948.1455637-1-keescook@chromium.org> <164462189850.7606.6908949862618145181.b4-ty@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Tue, Mar 08, 2022 at 10:20:28PM -0500, Martin K. Petersen wrote: > > Sreekanth, > > > I am observing below kernel panic when I load the driver with this > > patch changes. After reverting this patch changes then the driver is > > getting loaded successfully. > > I am puzzled. The driver loads fine for me. I have verified that the > generated object file is identical before and after Kees' patch. I've double-checked this again myself; I don't see any binary difference. Can you share your .config? I was using defconfig with these added: SCSI_LOWLEVEL=y SCSI_MPT3SAS=y -- Kees Cook