From: Kees Cook <keescook@chromium.org>
To: David Gow <davidgow@google.com>
Cc: "Gustavo A . R . Silva" <gustavoars@kernel.org>,
"KUnit Development" <kunit-dev@googlegroups.com>,
"Alexei Starovoitov" <ast@kernel.org>,
alsa-devel@alsa-project.org, "Al Viro" <viro@zeniv.linux.org.uk>,
"Andrew Gabbasov" <andrew_gabbasov@mentor.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Andy Gross" <agross@kernel.org>,
"Andy Lavr" <andy.lavr@gmail.com>,
"Arend van Spriel" <aspriel@gmail.com>,
"Baowen Zheng" <baowen.zheng@corigine.com>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Bradley Grove" <linuxdrivers@attotech.com>,
brcm80211-dev-list.pdl@broadcom.com,
"Christian Brauner" <brauner@kernel.org>,
"Christian Göttsche" <cgzones@googlemail.com>,
"Christian Lamparter" <chunkeey@googlemail.com>,
"Chris Zankel" <chris@zankel.net>,
"Cong Wang" <cong.wang@bytedance.com>,
"Daniel Axtens" <dja@axtens.net>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Dan Williams" <dan.j.williams@intel.com>,
"David Howells" <dhowells@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Dennis Dalessandro" <dennis.dalessandro@cornelisnetworks.com>,
devicetree@vger.kernel.org, "Dexuan Cui" <decui@microsoft.com>,
"Dmitry Kasatkin" <dmitry.kasatkin@gmail.com>,
"Eli Cohen" <elic@nvidia.com>,
"Eric Dumazet" <edumazet@google.com>,
"Eric Paris" <eparis@parisplace.org>,
"Eugeniu Rosca" <erosca@de.adit-jv.com>,
"Felipe Balbi" <balbi@kernel.org>,
"Francis Laniel" <laniel_francis@privacyrequired.com>,
"Frank Rowand" <frowand.list@gmail.com>,
"Franky Lin" <franky.lin@broadcom.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Gregory Greenman" <gregory.greenman@intel.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Hulk Robot" <hulkci@huawei.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"James Morris" <jmorris@namei.org>,
"Jarkko Sakkinen" <jarkko@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Jason Gunthorpe" <jgg@ziepe.ca>, "Jens Axboe" <axboe@kernel.dk>,
"Johan Hedberg" <johan.hedberg@gmail.com>,
"Johannes Berg" <johannes.berg@intel.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"John Keeping" <john@metanate.com>,
"Juergen Gross" <jgross@suse.com>,
"Kalle Valo" <kvalo@kernel.org>,
"Keith Packard" <keithp@keithp.com>,
keyrings@vger.kernel.org,
"Kuniyuki Iwashima" <kuniyu@amazon.co.jp>,
"K. Y. Srinivasan" <kys@microsoft.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Lee Jones" <lee.jones@linaro.org>,
"Leon Romanovsky" <leon@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux1394-devel@lists.sourceforge.net,
linux-afs@lists.infradead.org,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org,
linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org,
linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-scsi@vger.kernel.org,
linux-security-module <linux-security-module@vger.kernel.org>,
linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev,
"Loic Poulain" <loic.poulain@linaro.org>,
"Louis Peens" <louis.peens@corigine.com>,
"Luca Coelho" <luciano.coelho@intel.com>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
"Marcel Holtmann" <marcel@holtmann.org>,
"Mark Brown" <broonie@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Mimi Zohar" <zohar@linux.ibm.com>,
"Muchun Song" <songmuchun@bytedance.com>,
"Nathan Chancellor" <nathan@kernel.org>,
Networking <netdev@vger.kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Nuno Sá" <nuno.sa@analog.com>, "Paolo Abeni" <pabeni@redhat.com>,
"Paul Moore" <paul@paul-moore.com>,
"Rich Felker" <dalias@aerifal.cx>,
"Rob Herring" <robh+dt@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
selinux@vger.kernel.org, "Serge E. Hallyn" <serge@hallyn.com>,
SHA-cyfmac-dev-list@infineon.com,
"Simon Horman" <simon.horman@corigine.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Stefan Richter" <stefanr@s5r6.in-berlin.de>,
"Steffen Klassert" <steffen.klassert@secunet.com>,
"Stephen Hemminger" <sthemmin@microsoft.com>,
"Stephen Smalley" <stephen.smalley.work@gmail.com>,
"Tadeusz Struk" <tadeusz.struk@linaro.org>,
"Takashi Iwai" <tiwai@suse.com>, "Tom Rix" <trix@redhat.com>,
"Udipto Goswami" <quic_ugoswami@quicinc.com>,
"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
wcn36xx@lists.infradead.org, "Wei Liu" <wei.liu@kernel.org>,
xen-devel@lists.xenproject.org,
"Xiu Jianfeng" <xiujianfeng@huawei.com>,
"Yang Yingliang" <yangyingliang@huawei.com>
Subject: Re: [PATCH 03/32] flex_array: Add Kunit tests
Date: Wed, 4 May 2022 12:43:37 -0700 [thread overview]
Message-ID: <202205041220.4BAF15F6B4@keescook> (raw)
In-Reply-To: <CABVgOSn62JTxaX9BW8w8jRxOpf_vgxpW-s=amwo8PCotiZTjig@mail.gmail.com>
On Wed, May 04, 2022 at 11:00:38AM +0800, David Gow wrote:
> On Wed, May 4, 2022 at 9:47 AM Kees Cook <keescook@chromium.org> wrote:
> >
> > Add tests for the new flexible array structure helpers. These can be run
> > with:
> >
> > make ARCH=um mrproper
> > ./tools/testing/kunit/kunit.py config
>
> Nit: it shouldn't be necessary to run kunit.py config separately:
> kunit.py run will configure the kernel if necessary.
Ah yes, I think you mentioned this before. I'll adjust the commit log.
>
> > ./tools/testing/kunit/kunit.py run flex_array
> >
> > Cc: David Gow <davidgow@google.com>
> > Cc: kunit-dev@googlegroups.com
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> > ---
>
> This looks pretty good to me: it certainly worked on the different
> setups I tried (um, x86_64, x86_64+KASAN).
>
> A few minor nitpicks inline, mostly around minor config-y things, or
> things which weren't totally clear on my first read-through.
>
> Hopefully one day, with the various stubbing features or something
> similar, we'll be able to check against allocation failures in
> flex_dup(), too, but otherwise nothing seems too obviously missing.
>
> Reviewed-by: David Gow <davidgow@google.com>
Great; thanks for the review and testing!
>
> -- David
>
> > lib/Kconfig.debug | 12 +-
> > lib/Makefile | 1 +
> > lib/flex_array_kunit.c | 523 +++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 531 insertions(+), 5 deletions(-)
> > create mode 100644 lib/flex_array_kunit.c
> >
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index 9077bb38bc93..8bae6b169c50 100644
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -2551,11 +2551,6 @@ config OVERFLOW_KUNIT_TEST
> > Builds unit tests for the check_*_overflow(), size_*(), allocation, and
> > related functions.
> >
> > - For more information on KUnit and unit tests in general please refer
> > - to the KUnit documentation in Documentation/dev-tools/kunit/.
> > -
> > - If unsure, say N.
> > -
>
> Nit: while I'm not against removing some of this boilerplate, is it
> better suited for a separate commit?
Make sense, yes. I'll drop this for now.
>
> > config STACKINIT_KUNIT_TEST
> > tristate "Test level of stack variable initialization" if !KUNIT_ALL_TESTS
> > depends on KUNIT
> > @@ -2567,6 +2562,13 @@ config STACKINIT_KUNIT_TEST
> > CONFIG_GCC_PLUGIN_STRUCTLEAK, CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF,
> > or CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL.
> >
> > +config FLEX_ARRAY_KUNIT_TEST
> > + tristate "Test flex_*() family of helper functions at runtime" if !KUNIT_ALL_TESTS
> > + depends on KUNIT
> > + default KUNIT_ALL_TESTS
> > + help
> > + Builds unit tests for flexible array copy helper functions.
> > +
>
> Nit: checkpatch warns that the description here may be insufficient:
> WARNING: please write a help paragraph that fully describes the config symbol
Yeah, I don't know anything to put here that isn't just more
boilerplate, so I'm choosing to ignore this for now. :)
> > [...]
> > +struct normal {
> > + size_t datalen;
> > + u32 data[];
> > +};
> > +
> > +struct decl_normal {
> > + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(size_t, datalen);
> > + DECLARE_FLEX_ARRAY_ELEMENTS(u32, data);
> > +};
> > +
> > +struct aligned {
> > + unsigned short datalen;
> > + char data[] __aligned(__alignof__(u64));
> > +};
> > +
> > +struct decl_aligned {
> > + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(unsigned short, datalen);
> > + DECLARE_FLEX_ARRAY_ELEMENTS(char, data) __aligned(__alignof__(u64));
> > +};
> > +
> > +static void struct_test(struct kunit *test)
> > +{
> > + COMPARE_STRUCTS(struct normal, struct decl_normal);
> > + COMPARE_STRUCTS(struct aligned, struct decl_aligned);
> > +}
>
> If I understand it, the purpose of this is to ensure that structs both
> with and without the flexible array declaration have the same memory
> layout?
>
> If so, any chance of a comment briefly stating that's the purpose (or
> renaming this test struct_layout_test())?
Yeah, good idea; I'll improve the naming.
>
> Also, would it make sense to do the same with the struct with internal
> padding below?
Heh, yes, good point! :)
> [...]
> > +#define CHECK_COPY(ptr) do { \
> > + typeof(*(ptr)) *_cc_dst = (ptr); \
> > + KUNIT_EXPECT_EQ(test, _cc_dst->induce_padding, 0); \
> > + memcpy(&padding, &_cc_dst->induce_padding + sizeof(_cc_dst->induce_padding), \
> > + sizeof(padding)); \
> > + /* Padding should be zero too. */ \
> > + KUNIT_EXPECT_EQ(test, padding, 0); \
> > + KUNIT_EXPECT_EQ(test, src->count, _cc_dst->count); \
> > + KUNIT_EXPECT_EQ(test, _cc_dst->count, TEST_TARGET); \
> > + for (i = 0; i < _cc_dst->count - 1; i++) { \
> > + /* 'A' is 0x41, and here repeated in a u32. */ \
>
> Would it be simpler to just note that the magic value is 0x41, rather
> than have it be the character 'A'?
Yeah, now fixed.
> [...]
> > + CHECK_COPY(&encap->fas);
> > + /* Check that items external to "fas" are zero. */
> > + KUNIT_EXPECT_EQ(test, encap->flags, 0);
> > + KUNIT_EXPECT_EQ(test, encap->junk, 0);
> > + kfree(encap);
> > +#undef MAGIC_WORD
>
> MAGIC_WORD isn't defined (or used) for flux_dup_test? Is it worth
> using it (or something similar) for the 'A' / 0x14141414 and the
> CHECK_COPY() macro?
Oops, yes. Fixed.
Thanks again!
-Kees
--
Kees Cook
next prev parent reply other threads:[~2022-05-04 19:43 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 1:44 [PATCH 00/32] Introduce flexible array struct memcpy() helpers Kees Cook
2022-05-04 1:44 ` [PATCH 01/32] netlink: Avoid memcpy() across flexible array boundary Kees Cook
2022-05-04 3:31 ` Gustavo A. R. Silva
2022-05-04 3:37 ` Kees Cook
2022-05-04 1:44 ` [PATCH 02/32] Introduce flexible array struct memcpy() helpers Kees Cook
2022-05-04 7:25 ` Johannes Berg
2022-05-04 15:38 ` Kees Cook
2022-05-04 16:08 ` David Laight
2022-05-05 13:16 ` Johannes Berg
2022-05-05 15:16 ` Keith Packard
2022-05-05 19:32 ` Kees Cook
2022-05-05 20:08 ` Keith Packard
2022-05-05 20:12 ` Johannes Berg
2022-05-06 11:15 ` David Laight
2022-05-05 19:27 ` Kees Cook
2022-05-04 1:44 ` [PATCH 03/32] flex_array: Add Kunit tests Kees Cook
2022-05-04 3:00 ` David Gow
2022-05-04 19:43 ` Kees Cook [this message]
2022-05-04 19:58 ` Daniel Latypov
2022-05-04 1:44 ` [PATCH 04/32] fortify: Add run-time WARN for cross-field memcpy() Kees Cook
2022-05-04 1:44 ` [PATCH 05/32] brcmfmac: Use mem_to_flex_dup() with struct brcmf_fweh_queue_item Kees Cook
2022-05-04 1:44 ` [PATCH 06/32] iwlwifi: calib: Prepare to use mem_to_flex_dup() Kees Cook
2022-05-04 1:44 ` [PATCH 07/32] iwlwifi: calib: Use mem_to_flex_dup() with struct iwl_calib_result Kees Cook
2022-05-04 1:44 ` [PATCH 08/32] iwlwifi: mvm: Use mem_to_flex_dup() with struct ieee80211_key_conf Kees Cook
2022-05-04 1:44 ` [PATCH 09/32] p54: Use mem_to_flex_dup() with struct p54_cal_database Kees Cook
2022-05-04 1:44 ` [PATCH 10/32] wcn36xx: Use mem_to_flex_dup() with struct wcn36xx_hal_ind_msg Kees Cook
2022-05-04 5:42 ` Kalle Valo
2022-05-04 15:08 ` Kees Cook
2022-05-04 1:44 ` [PATCH 11/32] nl80211: Use mem_to_flex_dup() with struct cfg80211_cqm_config Kees Cook
2022-05-04 1:44 ` [PATCH 12/32] cfg80211: Use mem_to_flex_dup() with struct cfg80211_bss_ies Kees Cook
2022-05-04 7:28 ` Johannes Berg
2022-05-04 15:13 ` Kees Cook
2022-05-04 1:44 ` [PATCH 13/32] mac80211: Use mem_to_flex_dup() with several structs Kees Cook
2022-05-04 1:44 ` [PATCH 14/32] af_unix: Use mem_to_flex_dup() with struct unix_address Kees Cook
2022-05-04 1:44 ` [PATCH 15/32] 802/garp: Use mem_to_flex_dup() with struct garp_attr Kees Cook
2022-05-04 1:44 ` [PATCH 16/32] 802/mrp: Use mem_to_flex_dup() with struct mrp_attr Kees Cook
2022-05-04 1:44 ` [PATCH 17/32] net/flow_offload: Use mem_to_flex_dup() with struct flow_action_cookie Kees Cook
2022-05-04 1:44 ` [PATCH 18/32] firewire: Use __mem_to_flex_dup() with struct iso_interrupt_event Kees Cook
2022-05-04 1:44 ` [PATCH 19/32] afs: Use mem_to_flex_dup() with struct afs_acl Kees Cook
2022-05-04 1:44 ` [PATCH 20/32] ASoC: sigmadsp: Use mem_to_flex_dup() with struct sigmadsp_data Kees Cook
2022-05-04 15:17 ` Mark Brown
2022-05-04 1:44 ` [PATCH 21/32] soc: qcom: apr: Use mem_to_flex_dup() with struct apr_rx_buf Kees Cook
2022-05-04 1:44 ` [PATCH 22/32] atags_proc: Use mem_to_flex_dup() with struct buffer Kees Cook
2022-05-04 1:44 ` [PATCH 23/32] Bluetooth: Use mem_to_flex_dup() with struct hci_op_configure_data_path Kees Cook
2022-05-04 1:44 ` [PATCH 24/32] IB/hfi1: Use mem_to_flex_dup() for struct tid_rb_node Kees Cook
2022-05-04 1:44 ` [PATCH 25/32] Drivers: hv: utils: Use mem_to_flex_dup() with struct cn_msg Kees Cook
2022-05-04 1:44 ` [PATCH 26/32] ima: Use mem_to_flex_dup() with struct modsig Kees Cook
2022-05-04 1:44 ` [PATCH 27/32] KEYS: Use mem_to_flex_dup() with struct user_key_payload Kees Cook
2022-05-04 1:44 ` [PATCH 28/32] selinux: Use mem_to_flex_dup() with xfrm and sidtab Kees Cook
2022-05-04 22:57 ` Paul Moore
2022-05-04 23:43 ` Gustavo A. R. Silva
2022-05-05 3:14 ` Paul Moore
2022-05-05 18:39 ` Kees Cook
2022-05-05 23:16 ` Paul Moore
2022-05-06 1:08 ` Gustavo A. R. Silva
2022-05-04 1:44 ` [PATCH 29/32] xtensa: Use mem_to_flex_dup() with struct property Kees Cook
2022-05-04 18:09 ` Rob Herring
2022-05-04 1:44 ` [PATCH 30/32] usb: gadget: f_fs: Use mem_to_flex_dup() with struct ffs_buffer Kees Cook
2022-05-04 1:44 ` [PATCH 31/32] xenbus: Use mem_to_flex_dup() with struct read_buffer Kees Cook
2022-05-04 1:44 ` [PATCH 32/32] esas2r: Use __mem_to_flex() with struct atto_ioctl Kees Cook
2022-05-12 21:41 ` [PATCH 19/32] afs: Use mem_to_flex_dup() with struct afs_acl David Howells
2022-05-13 15:44 ` Kees Cook
2022-05-12 21:47 ` [PATCH 00/32] Introduce flexible array struct memcpy() helpers David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205041220.4BAF15F6B4@keescook \
--to=keescook@chromium.org \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=agross@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=andrew_gabbasov@mentor.com \
--cc=andy.lavr@gmail.com \
--cc=aspriel@gmail.com \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=balbi@kernel.org \
--cc=baowen.zheng@corigine.com \
--cc=bjorn.andersson@linaro.org \
--cc=boris.ostrovsky@oracle.com \
--cc=brauner@kernel.org \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=broonie@kernel.org \
--cc=cgzones@googlemail.com \
--cc=chris@zankel.net \
--cc=chunkeey@googlemail.com \
--cc=cong.wang@bytedance.com \
--cc=dalias@aerifal.cx \
--cc=dan.j.williams@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=davem@davemloft.net \
--cc=davidgow@google.com \
--cc=decui@microsoft.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=devicetree@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=dja@axtens.net \
--cc=dmitry.kasatkin@gmail.com \
--cc=edumazet@google.com \
--cc=elic@nvidia.com \
--cc=eparis@parisplace.org \
--cc=erosca@de.adit-jv.com \
--cc=franky.lin@broadcom.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.greenman@intel.com \
--cc=gustavoars@kernel.org \
--cc=haiyangz@microsoft.com \
--cc=hante.meuleman@broadcom.com \
--cc=herbert@gondor.apana.org.au \
--cc=hulkci@huawei.com \
--cc=jarkko@kernel.org \
--cc=jcmvbkbc@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jgross@suse.com \
--cc=jmorris@namei.org \
--cc=johan.hedberg@gmail.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=john@metanate.com \
--cc=keithp@keithp.com \
--cc=keyrings@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=kuniyu@amazon.co.jp \
--cc=kvalo@kernel.org \
--cc=kys@microsoft.com \
--cc=laniel_francis@privacyrequired.com \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=leon@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=linuxdrivers@attotech.com \
--cc=llvm@lists.linux.dev \
--cc=loic.poulain@linaro.org \
--cc=louis.peens@corigine.com \
--cc=luciano.coelho@intel.com \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=martin.petersen@oracle.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pabeni@redhat.com \
--cc=paul@paul-moore.com \
--cc=perex@perex.cz \
--cc=quic_ugoswami@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=simon.horman@corigine.com \
--cc=songmuchun@bytedance.com \
--cc=sstabellini@kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=steffen.klassert@secunet.com \
--cc=stephen.smalley.work@gmail.com \
--cc=sthemmin@microsoft.com \
--cc=tadeusz.struk@linaro.org \
--cc=tiwai@suse.com \
--cc=trix@redhat.com \
--cc=vincenzo.frascino@arm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wcn36xx@lists.infradead.org \
--cc=wei.liu@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xiujianfeng@huawei.com \
--cc=yangyingliang@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).