From: Kees Cook <keescook@chromium.org>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Gunthorpe <jgg@ziepe.ca>, Nishanth Menon <nm@ti.com>,
Michael Kelley <mikelley@microsoft.com>,
Dan Williams <dan.j.williams@intel.com>,
Won Chung <wonchung@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] driver core: Add __alloc_size hint to devm allocators
Date: Tue, 18 Oct 2022 03:15:36 -0700 [thread overview]
Message-ID: <202210180310.A13EAA7@keescook> (raw)
In-Reply-To: <d199c2af-06af-8a50-a6a1-00eefa0b67b4@prevas.dk>
On Tue, Oct 18, 2022 at 12:09:30PM +0200, Rasmus Villemoes wrote:
> On 18/10/2022 09.34, Kees Cook wrote:
> > Mark the devm_*alloc()-family of allocations with appropriate
> > __alloc_size() hints so the compiler can attempt to reason about buffer
> > lengths from allocations.
> >
>
> > @@ -226,7 +226,8 @@ static inline void *devm_kcalloc(struct device *dev,
> > void devm_kfree(struct device *dev, const void *p);
> > char *devm_kstrdup(struct device *dev, const char *s, gfp_t gfp) __malloc;
> > const char *devm_kstrdup_const(struct device *dev, const char *s, gfp_t gfp);
> > -void *devm_kmemdup(struct device *dev, const void *src, size_t len, gfp_t gfp);
> > +void *devm_kmemdup(struct device *dev, const void *src, size_t len, gfp_t gfp)
> > + __alloc_size(3);
>
> I think it's wrong to apply the __malloc attribute to kmemdup() and
> variants.
>
> 'malloc'
> This tells the compiler that a function is 'malloc'-like, i.e.,
> that the pointer P returned by the function cannot alias any other
> pointer valid when the function returns, and moreover no pointers
> to valid objects occur in any storage addressed by P.
Oh, ew, it defines rules about _contents_ as well. Thank you for
pointing that out!
I suppose we can use __realloc_size for these cases then?
--
Kees Cook
next prev parent reply other threads:[~2022-10-18 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 7:34 [PATCH] driver core: Add __alloc_size hint to devm allocators Kees Cook
2022-10-18 10:09 ` Rasmus Villemoes
2022-10-18 10:15 ` Kees Cook [this message]
2022-10-18 10:43 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202210180310.A13EAA7@keescook \
--to=keescook@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=nm@ti.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=tglx@linutronix.de \
--cc=wonchung@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).