From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F0D3C7EE24 for ; Tue, 16 May 2023 20:50:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229721AbjEPUui (ORCPT ); Tue, 16 May 2023 16:50:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229888AbjEPUuh (ORCPT ); Tue, 16 May 2023 16:50:37 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98A7DE56 for ; Tue, 16 May 2023 13:50:35 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-5307502146aso4969320a12.1 for ; Tue, 16 May 2023 13:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1684270235; x=1686862235; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zQwO1AW86ZZMLv1I226cO+hnWHW8xIqRy3E2TLcdclA=; b=fFhG9M9BqB2Jhhucg0HrxXSX2VDAxo8VMXPAmarNkjhKXtKNnIKwpdr5CJY72A6B3n I7Ups187ntxJFuKWvFdd4ZS3604bvLbMPjDvPhSmshRWSMvI9fNpZDE1Jzg7WhICSmZq IlXhZj1G/aY1nBpyMbqOO7qk3Nj2BP+W4FP7g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684270235; x=1686862235; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zQwO1AW86ZZMLv1I226cO+hnWHW8xIqRy3E2TLcdclA=; b=SoTffUWZe4ZDprVAi21ErKdh/TCZyK0yZWrCUBsBzeUIQ9CtlHFj1TRjz8MzHynpaR lErhXRhovGopVAS/fMnUpYikmBmgJpQL04A8lfAmD9o52AJWinZJqSue/sLZNRXuS4Nj ayVew8I5v1iRaGv1SPvIsBJOMdtqXwr7QUvNdyy1XLJgStGEZ178nV2uF5SmHHM+uboS WYXllgHXbxiNNyVvBqinA5YjdHiXM3Klnnlj59RcMlrdXYG2XsoF7ouNZ2qcsehICC9Z hUzOOWkfqc1geLI4mHSrhRoydBzlF1PRUsMWqw73DYqVnErDnP3ha+R4+/WHoMDCiZya iZkg== X-Gm-Message-State: AC+VfDz/aMXjkjVGEnHafeQuL4fRGw8pSzmmqfYSpUVaXtCbaeyw7QLq +Bgka0AD4DKExW4PpVBGk/mcNA== X-Google-Smtp-Source: ACHHUZ7zbSTqF2+Ctw96wBfV5FayFZLDDyPrQ785jpE1+sute7vYZzIO1eBBcnyFwmB5G5I0TAFTNA== X-Received: by 2002:a05:6a20:7d97:b0:ff:e60c:ee93 with SMTP id v23-20020a056a207d9700b000ffe60cee93mr43232036pzj.26.1684270235098; Tue, 16 May 2023 13:50:35 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id i13-20020aa7908d000000b0063f2e729127sm14237746pfa.144.2023.05.16.13.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 13:50:34 -0700 (PDT) Date: Tue, 16 May 2023 13:50:33 -0700 From: Kees Cook To: Mukesh Ojha Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, corbet@lwn.net, tony.luck@intel.com, gpiccoli@igalia.com, catalin.marinas@arm.com, will@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 12/18] soc: qcom: Register pstore frontend region with minidump Message-ID: <202305161349.7306F11199@keescook> References: <1683133352-10046-1-git-send-email-quic_mojha@quicinc.com> <1683133352-10046-13-git-send-email-quic_mojha@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1683133352-10046-13-git-send-email-quic_mojha@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Wed, May 03, 2023 at 10:32:26PM +0530, Mukesh Ojha wrote: > Since qcom_pstore_minidump driver creates platform device > for qualcomm devices, so it knows the physical addresses > of the frontend region now. Let's register the regions > with qcom_minidump driver. > > Signed-off-by: Mukesh Ojha > [...] > + strlcpy(md_region->name, name, sizeof(md_region->name)); nitpick throughout: Please use strscpy() https://github.com/KSPP/linux/issues/89 -Kees -- Kees Cook