From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 722E1C7EE23 for ; Fri, 26 May 2023 17:25:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229964AbjEZRZR (ORCPT ); Fri, 26 May 2023 13:25:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229581AbjEZRZR (ORCPT ); Fri, 26 May 2023 13:25:17 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C651FFB for ; Fri, 26 May 2023 10:25:14 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1ae763f9c0bso7529315ad.2 for ; Fri, 26 May 2023 10:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1685121914; x=1687713914; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KfNMXGcl/NoZyU1TMuXBgw5Vf3pYoZn7mpjEnfq/Mik=; b=a2oyvZaTloig24bEWaQzdNYWUOL6m4mXSiAbb6RBBz3Nc0GhC8q8035ImW8YDXfsUh oGlubxkuDhTTF5XTYh+RJ/MelMM+4absRCAZcrauneIQ70uzQgAPm0DV/Rna0GC9XW0f KuUeY+ky/cJoSnfql03OzSnmi4beNTvmrjrN0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685121914; x=1687713914; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KfNMXGcl/NoZyU1TMuXBgw5Vf3pYoZn7mpjEnfq/Mik=; b=WlqPV4cF8ycovGGslgTF6j+w6tAPskHhcA4K9dDiIyG5DtzlX1w3b+eRZq0sIVlCs3 pDiyAYPELupCoMkHYLrvmkiPx4+Um8jvU05J4lM+mlzzPWVx1kuhcyxqaZ8uUZ7Ajcqq CxAy1ACDM3RKIN/rqB0I9G7bUYVuzrbmAKzwKv+oyPZDRh0WWfl8vKMXXoP02wkWNlot 252IVugWpc2SQiuFM68IXpfIKez54xsojY82vUb+Vp2Z87tJsKWXiuzKEGKBStHch92l u8KLHR27fFp/ww11pFJ1bClprFrEBc+/p5WKcqtzV1c8ZOy8eCwgh2xSZpx5D+mY4xmN Zvzg== X-Gm-Message-State: AC+VfDwAneaViuIOjebr1xEh8SNbD93l+ZhU+2lNX2n28CldVQPUymuG jjexm4cdEZMstFCgD9IldnvQRw== X-Google-Smtp-Source: ACHHUZ7akEKdSRLtn7ET8rqSs2dwk9Y3rO9LoKvADJjmViawMnhh116yZkVkCI78s7Mf0hw1qQBjxA== X-Received: by 2002:a17:902:db02:b0:1ac:750e:33ef with SMTP id m2-20020a170902db0200b001ac750e33efmr4095459plx.3.1685121913871; Fri, 26 May 2023 10:25:13 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id d13-20020a170902cecd00b001a064282b11sm3494052plg.151.2023.05.26.10.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 10:25:13 -0700 (PDT) From: Kees Cook To: Andy Whitcroft Cc: Kees Cook , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH v2] checkpatch: Check for strcpy and strncpy too Date: Fri, 26 May 2023 10:25:11 -0700 Message-Id: <20230526172508.gonna.793-kees@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1830; h=from:subject:message-id; bh=gR1dVrDDLBhiUgLe7nt7jcC1so04DAJwfqgytUoUlaU=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBkcOt33rxJ0GO+/P9Nn4/quZbyds5yHyTRcxPEVafB 5vT4zqaJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCZHDrdwAKCRCJcvTf3G3AJsqnD/ wNivL/mRH0uKxIm3r4cWNygeKy4bnw9P3mIryMSk/WWOkkzk/n/JMP+xAB/eCsXtdaZHcqEyyFWlZx QQVvFKON49UxTBpwx6D1P6Vvfn5RgXs2nKoIAAqgdyuURSWCwL/EGnSxb18EvD7DvkQay/n+UYl2gr udS9AyFd34M/GO60vjhQFgdroTmb0l/d7zfvVATewDowfPiccY4x5TjsDhYGREjdkCdrbcueDTBQ+k XyYKMQugRGefzHhe+aRYVe8f+QKHyZV9rZrDEpmmIs+mWddmwKhkr3wkHupDhiyGqKAV6Y6SEF3YDQ qkr8SfRwc3f//P3C5/+MO3oCGez0hW1Wt0lggTcuqkGx7avoYaAQdvwGnrknuPFiMLNZQ+ndzZtGKu zRWQ6P57N6T/i0BgEfMJfJK3xKY/bfMCepxBbjgamK2ayCwUNokXl/++oNrRTboekxX1an0QR11Bpq Nnd7+U02kCEOcM3KvP3mtml/IPYjW+WmiAXXIHMFrPzgfLw6ZiZLxurHbu0I5bVxu1XxYY/5jc3NYd efV+1L8ZN14Dh9mqIf4o1cIb8IBp1cB6e/MjhxPUyt/OY9LFJV1angi8zm+zGPSCpBd6tZoryJb2Km WgHWm/5PYtgvXQ66+OpCb5oWS6lqpkl0VU5rc+H7CXpzv4L0qqns+PuZorLA== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org Warn about strcpy(), strncpy(), and strlcpy(). Suggest strscpy() and include pointers to the open KSPP issues for each, which has further details and replacement procedures. Cc: Andy Whitcroft Cc: Joe Perches Cc: Dwaipayan Ray Cc: Lukas Bulwahn Signed-off-by: Kees Cook Link: https://lore.kernel.org/r/20230517201349.never.582-kees@kernel.org --- v2: change language to use "Prefer ... over ..." (joe) v1: https://lore.kernel.org/lkml/20230517201349.never.582-kees@kernel.org/ --- scripts/checkpatch.pl | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b30114d637c4..30b0b4fdb3bf 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6997,10 +6997,22 @@ sub process { # } # } +# strcpy uses that should likely be strscpy + if ($line =~ /\bstrcpy\s*\(/) { + WARN("STRCPY", + "Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88\n" . $herecurr); + } + # strlcpy uses that should likely be strscpy if ($line =~ /\bstrlcpy\s*\(/) { WARN("STRLCPY", - "Prefer strscpy over strlcpy - see: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw\@mail.gmail.com/\n" . $herecurr); + "Prefer strscpy over strlcpy - see: https://github.com/KSPP/linux/issues/89\n" . $herecurr); + } + +# strncpy uses that should likely be strscpy or strscpy_pad + if ($line =~ /\bstrncpy\s*\(/) { + WARN("STRNCPY", + "Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90\n" . $herecurr); } # typecasts on min/max could be min_t/max_t -- 2.34.1