* [PATCH v2][next] afs: Fix fall-through warnings for Clang
@ 2021-04-20 21:16 Gustavo A. R. Silva
2021-04-21 23:03 ` Jeffrey E Altman
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-04-20 21:16 UTC (permalink / raw)
To: David Howells
Cc: linux-afs, linux-kernel, Gustavo A. R. Silva, linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple fallthrough pseudo-keywords
in places where the code is intended to fall through to the next
case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
Changes in v2:
- Place blank line after the fallthrough markings, not before.
Link: https://lore.kernel.org/linux-hardening/748935.1606147853@warthog.procyon.org.uk/
fs/afs/cmservice.c | 5 +++++
fs/afs/fsclient.c | 4 ++++
fs/afs/vlclient.c | 1 +
3 files changed, 10 insertions(+)
diff --git a/fs/afs/cmservice.c b/fs/afs/cmservice.c
index a4e9e6e07e93..d3c6bb22c5f4 100644
--- a/fs/afs/cmservice.c
+++ b/fs/afs/cmservice.c
@@ -322,6 +322,8 @@ static int afs_deliver_cb_callback(struct afs_call *call)
return ret;
call->unmarshall++;
+ fallthrough;
+
case 5:
break;
}
@@ -418,6 +420,7 @@ static int afs_deliver_cb_init_call_back_state3(struct afs_call *call)
r->node[loop] = ntohl(b[loop + 5]);
call->unmarshall++;
+ fallthrough;
case 2:
break;
@@ -530,6 +533,7 @@ static int afs_deliver_cb_probe_uuid(struct afs_call *call)
r->node[loop] = ntohl(b[loop + 5]);
call->unmarshall++;
+ fallthrough;
case 2:
break;
@@ -663,6 +667,7 @@ static int afs_deliver_yfs_cb_callback(struct afs_call *call)
afs_extract_to_tmp(call);
call->unmarshall++;
+ fallthrough;
case 3:
break;
diff --git a/fs/afs/fsclient.c b/fs/afs/fsclient.c
index 2f695a260442..dd3f45d906d2 100644
--- a/fs/afs/fsclient.c
+++ b/fs/afs/fsclient.c
@@ -388,6 +388,7 @@ static int afs_deliver_fs_fetch_data(struct afs_call *call)
req->file_size = vp->scb.status.size;
call->unmarshall++;
+ fallthrough;
case 5:
break;
@@ -1408,6 +1409,7 @@ static int afs_deliver_fs_get_volume_status(struct afs_call *call)
_debug("motd '%s'", p);
call->unmarshall++;
+ fallthrough;
case 8:
break;
@@ -1845,6 +1847,7 @@ static int afs_deliver_fs_inline_bulk_status(struct afs_call *call)
xdr_decode_AFSVolSync(&bp, &op->volsync);
call->unmarshall++;
+ fallthrough;
case 6:
break;
@@ -1979,6 +1982,7 @@ static int afs_deliver_fs_fetch_acl(struct afs_call *call)
xdr_decode_AFSVolSync(&bp, &op->volsync);
call->unmarshall++;
+ fallthrough;
case 4:
break;
diff --git a/fs/afs/vlclient.c b/fs/afs/vlclient.c
index dc9327332f06..00fca3c66ba6 100644
--- a/fs/afs/vlclient.c
+++ b/fs/afs/vlclient.c
@@ -593,6 +593,7 @@ static int afs_deliver_yfsvl_get_endpoints(struct afs_call *call)
if (ret < 0)
return ret;
call->unmarshall = 6;
+ fallthrough;
case 6:
break;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2][next] afs: Fix fall-through warnings for Clang
2021-04-20 21:16 [PATCH v2][next] afs: Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2021-04-21 23:03 ` Jeffrey E Altman
2021-05-18 0:33 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Jeffrey E Altman @ 2021-04-21 23:03 UTC (permalink / raw)
To: Gustavo A. R. Silva (gustavoars@kernel.org), David Howells
Cc: linux-afs, linux-kernel, linux-hardening
[-- Attachment #1.1.1: Type: text/plain, Size: 691 bytes --]
On 4/20/2021 5:16 PM, Gustavo A. R. Silva (gustavoars@kernel.org) wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding multiple fallthrough pseudo-keywords
> in places where the code is intended to fall through to the next
> case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> Changes in v2:
> - Place blank line after the fallthrough markings, not before.
> Link: https://lore.kernel.org/linux-hardening/748935.1606147853@warthog.procyon.org.uk/
This change looks good to me.
Reviewed-by: Jeffrey Altman <jaltman@auristor.com>
[-- Attachment #1.1.2: jaltman.vcf --]
[-- Type: text/x-vcard, Size: 283 bytes --]
begin:vcard
fn:Jeffrey Altman
n:Altman;Jeffrey
org:AuriStor, Inc.
adr:;;255 W 94TH ST STE 6B;New York;NY;10025-6985;United States
email;internet:jaltman@auristor.com
title:CEO
tel;work:+1-212-769-9018
url:https://www.linkedin.com/in/jeffreyaltman/
version:2.1
end:vcard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2][next] afs: Fix fall-through warnings for Clang
2021-04-21 23:03 ` Jeffrey E Altman
@ 2021-05-18 0:33 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-05-18 0:33 UTC (permalink / raw)
To: Jeffrey E Altman, Gustavo A. R. Silva (gustavoars@kernel.org),
David Howells
Cc: linux-afs, linux-kernel, linux-hardening
On 4/21/21 18:03, Jeffrey E Altman wrote:
> On 4/20/2021 5:16 PM, Gustavo A. R. Silva (gustavoars@kernel.org) wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
>> warnings by explicitly adding multiple fallthrough pseudo-keywords
>> in places where the code is intended to fall through to the next
>> case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>> ---
>> Changes in v2:
>> - Place blank line after the fallthrough markings, not before.
>> Link: https://lore.kernel.org/linux-hardening/748935.1606147853@warthog.procyon.org.uk/
>
> This change looks good to me.
>
> Reviewed-by: Jeffrey Altman <jaltman@auristor.com>
Thanks, Jeffrey.
Could someone take this, please?
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-18 0:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 21:16 [PATCH v2][next] afs: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-04-21 23:03 ` Jeffrey E Altman
2021-05-18 0:33 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).