From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Kalle Valo <kvalo@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
Luca Coelho <luciano.coelho@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] iwlwifi: fw: Replace zero-length arrays with flexible-array members
Date: Mon, 28 Mar 2022 01:23:59 -0500 [thread overview]
Message-ID: <4c520e2e-d1a5-6d2b-3ef1-b891d7946c01@embeddedor.com> (raw)
In-Reply-To: <871qym1vck.fsf@kernel.org>
On 3/28/22 00:47, Kalle Valo wrote:
> "Gustavo A. R. Silva" <gustavoars@kernel.org> writes:
>
>> On Wed, Feb 16, 2022 at 12:35:14PM -0800, Kees Cook wrote:
>>> On Wed, Feb 16, 2022 at 01:50:15PM -0600, Gustavo A. R. Silva wrote:
>>>> There is a regular need in the kernel to provide a way to declare
>>>> having a dynamically sized set of trailing elements in a structure.
>>>> Kernel code should always use “flexible array members”[1] for these
>>>> cases. The older style of one-element or zero-length arrays should
>>>> no longer be used[2].
>>>>
>>>> [1] https://en.wikipedia.org/wiki/Flexible_array_member
>>>> [2]
>>>> https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
>>>>
>>>> Link: https://github.com/KSPP/linux/issues/78
>>>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>>>
>>> Reviewed-by: Kees Cook <keescook@chromium.org>
>>
>> Hi all,
>>
>> Friendly ping: can someone take this, please?
>>
>> ...I can take this in my -next tree in the meantime.
>
> Like we have discussed before, please don't take any wireless patches to
> your tree. The conflicts just cause more work of us.
Sure thing. I just removed it from my tree.
I didn't get any reply from wireless people in more than a month, and
that's why I temporarily took it in my tree so it doesn't get lost. :)
> I assigned this patch to me on patchwork and I'm planning to take it to
> wireless-next once it opens. Luca, ack?
Awesome.
Thanks
--
Gustavo
next prev parent reply other threads:[~2022-03-28 6:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 19:50 [PATCH][next] iwlwifi: fw: Replace zero-length arrays with flexible-array members Gustavo A. R. Silva
2022-02-16 20:35 ` Kees Cook
2022-03-26 0:38 ` Gustavo A. R. Silva
2022-03-28 5:47 ` Kalle Valo
2022-03-28 6:23 ` Gustavo A. R. Silva [this message]
2022-04-01 8:10 ` Coelho, Luciano
2022-04-01 11:43 ` Kalle Valo
2022-04-06 7:18 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c520e2e-d1a5-6d2b-3ef1-b891d7946c01@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).