From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: linux-hams@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH RESEND][next] net: netrom: Fix fall-through warnings for Clang
Date: Tue, 20 Apr 2021 15:11:00 -0500 [thread overview]
Message-ID: <5047001a-e5a8-ec64-0dc7-662e7cb0d100@embeddedor.com> (raw)
In-Reply-To: <20210305092210.GA139864@embeddedor>
Hi all,
Friendly ping: who can take this, please?
Thanks
--
Gustavo
On 3/5/21 03:22, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding multiple break statements instead of
> letting the code fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> net/netrom/nr_route.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
> index 78da5eab252a..de9821b6a62a 100644
> --- a/net/netrom/nr_route.c
> +++ b/net/netrom/nr_route.c
> @@ -266,6 +266,7 @@ static int __must_check nr_add_node(ax25_address *nr, const char *mnemonic,
> fallthrough;
> case 2:
> re_sort_routes(nr_node, 0, 1);
> + break;
> case 1:
> break;
> }
> @@ -359,6 +360,7 @@ static int nr_del_node(ax25_address *callsign, ax25_address *neighbour, struct n
> fallthrough;
> case 1:
> nr_node->routes[1] = nr_node->routes[2];
> + break;
> case 2:
> break;
> }
> @@ -482,6 +484,7 @@ static int nr_dec_obs(void)
> fallthrough;
> case 1:
> s->routes[1] = s->routes[2];
> + break;
> case 2:
> break;
> }
> @@ -529,6 +532,7 @@ void nr_rt_device_down(struct net_device *dev)
> fallthrough;
> case 1:
> t->routes[1] = t->routes[2];
> + break;
> case 2:
> break;
> }
>
next prev parent reply other threads:[~2021-04-20 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 9:22 [PATCH RESEND][next] net: netrom: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-04-20 20:11 ` Gustavo A. R. Silva [this message]
2021-05-17 20:09 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5047001a-e5a8-ec64-0dc7-662e7cb0d100@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).