linux-hardening.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Kees Cook <keescook@chromium.org>, Daniel Latypov <dlatypov@google.com>
Cc: David Gow <davidgow@google.com>,
	Vitor Massaru Iha <vitor@massaru.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org,
	KUnit Development <kunit-dev@googlegroups.com>,
	linux-kselftest@vger.kernel.org, linux-hardening@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] lib: overflow: Convert to Kunit
Date: Thu, 17 Feb 2022 10:24:44 -0700	[thread overview]
Message-ID: <68057bea-7bf7-afb9-4c99-aa3b2c024133@linuxfoundation.org> (raw)
In-Reply-To: <202202170903.E39554DF@keescook>

On 2/17/22 10:09 AM, Kees Cook wrote:
> On Wed, Feb 16, 2022 at 02:57:12PM -0800, Daniel Latypov wrote:
>> On Wed, Feb 16, 2022 at 2:42 PM Kees Cook <keescook@chromium.org> wrote:
>>>
>>> Convert overflow unit tests to KUnit, for better integration into the
>>> kernel self test framework. Includes a rename of test_overflow.c to
>>> overflow_kunit.c, and CONFIG_TEST_OVERFLOW to CONFIG_OVERFLOW_KUNIT_TEST.
>>>
>>> $ ./tools/testing/kunit/kunit.py config
>>> ...
>>> $ ./tools/testing/kunit/kunit.py run overflow
>>
>> JFYI, you can run this as a one-liner via
>>
>> $ ./tools/testing/kunit/kunit.py run --kunitconfig /dev/stdin <<EOF
>> CONFIG_KUNIT=y
>> CONFIG_TEST_OVERFLOW=y
>> EOF
>>
>> The above is taken from my own duplicate version of this patch
>> [1] https://lore.kernel.org/linux-kselftest/20210503211536.1384578-1-dlatypov@google.com/
> 
> Ah-ha! I thought I remembered this conversion being proposed before but
> I totally failed to find it. Thank you! I'll compare/adjust this patch
> and add you as Co-developed-by.
> 
>>> ...
>>> [14:33:51] Starting KUnit Kernel (1/1)...
>>> [14:33:51] ============================================================
>>> [14:33:51] ================== overflow (11 subtests) ==================
>>> [14:33:51] [PASSED] u8_overflow_test
>>> [14:33:51] [PASSED] s8_overflow_test
>>> [14:33:51] [PASSED] u16_overflow_test
>>> [14:33:51] [PASSED] s16_overflow_test
>>> [14:33:51] [PASSED] u32_overflow_test
>>> [14:33:51] [PASSED] s32_overflow_test
>>> [14:33:51] [PASSED] u64_overflow_test
>>> [14:33:51] [PASSED] s64_overflow_test
>>> [14:33:51] [PASSED] overflow_shift_test
>>> [14:33:51] [PASSED] overflow_allocation_test
>>> [14:33:51] [PASSED] overflow_size_helpers_test
>>> [14:33:51] ==================== [PASSED] overflow =====================
>>> [14:33:51] ============================================================
>>> [14:33:51] Testing complete. Passed: 11, Failed: 0, Crashed: 0, Skipped: 0, Errors: 0
>>> [14:33:51] Elapsed time: 12.525s total, 0.001s configuring, 12.402s building, 0.101s running
>>>
>>> Cc: David Gow <davidgow@google.com>
>>> Cc: Vitor Massaru Iha <vitor@massaru.org>
>>> Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>>> Cc: Nick Desaulniers <ndesaulniers@google.com>
>>> Co-developed-by: Vitor Massaru Iha <vitor@massaru.org>
>>> Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
>>> Link: https://lore.kernel.org/lkml/20200720224418.200495-1-vitor@massaru.org/
>>> Signed-off-by: Kees Cook <keescook@chromium.org>
>>
>> Reviewed-by: Daniel Latypov <dlatypov@google.com>
>>

Looks good to me. I recall reviewing this when Vitor was working on this.
Glad to this happen.

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah

  reply	other threads:[~2022-02-17 17:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16 22:41 [PATCH] lib: overflow: Convert to Kunit Kees Cook
2022-02-16 22:47 ` Nick Desaulniers
2022-02-16 22:57 ` Daniel Latypov
2022-02-17 17:09   ` Kees Cook
2022-02-17 17:24     ` Shuah Khan [this message]
2022-02-17 19:01     ` Daniel Latypov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68057bea-7bf7-afb9-4c99-aa3b2c024133@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=davidgow@google.com \
    --cc=dlatypov@google.com \
    --cc=keescook@chromium.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=ndesaulniers@google.com \
    --cc=vitor@massaru.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).