* [PATCH][next] tw89: core.h: Replace zero-length array with flexible-array member
@ 2022-02-16 19:50 Gustavo A. R. Silva
2022-02-16 20:35 ` Kees Cook
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2022-02-16 19:50 UTC (permalink / raw)
To: Ping-Ke Shih, Kalle Valo, David S. Miller, Jakub Kicinski
Cc: linux-wireless, netdev, linux-kernel, Gustavo A. R. Silva,
linux-hardening
There is a regular need in the kernel to provide a way to declare
having a dynamically sized set of trailing elements in a structure.
Kernel code should always use “flexible array members”[1] for these
cases. The older style of one-element or zero-length arrays should
no longer be used[2].
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
Link: https://github.com/KSPP/linux/issues/78
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/wireless/realtek/rtw89/core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h
index 7c84556ec4ad..b15b529e19ed 100644
--- a/drivers/net/wireless/realtek/rtw89/core.h
+++ b/drivers/net/wireless/realtek/rtw89/core.h
@@ -2847,7 +2847,7 @@ struct rtw89_dev {
int napi_budget_countdown;
/* HCI related data, keep last */
- u8 priv[0] __aligned(sizeof(void *));
+ u8 priv[] __aligned(sizeof(void *));
};
static inline int rtw89_hci_tx_write(struct rtw89_dev *rtwdev,
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH][next] tw89: core.h: Replace zero-length array with flexible-array member
2022-02-16 19:50 [PATCH][next] tw89: core.h: Replace zero-length array with flexible-array member Gustavo A. R. Silva
@ 2022-02-16 20:35 ` Kees Cook
2022-02-17 0:25 ` Pkshih
2022-02-17 2:42 ` Jakub Kicinski
2022-02-21 9:01 ` [next] rtw89: " Kalle Valo
2 siblings, 1 reply; 6+ messages in thread
From: Kees Cook @ 2022-02-16 20:35 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Ping-Ke Shih, Kalle Valo, David S. Miller, Jakub Kicinski,
linux-wireless, netdev, linux-kernel, linux-hardening
On Wed, Feb 16, 2022 at 01:50:47PM -0600, Gustavo A. R. Silva wrote:
> There is a regular need in the kernel to provide a way to declare
> having a dynamically sized set of trailing elements in a structure.
> Kernel code should always use “flexible array members”[1] for these
> cases. The older style of one-element or zero-length arrays should
> no longer be used[2].
>
> [1] https://en.wikipedia.org/wiki/Flexible_array_member
> [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
>
> Link: https://github.com/KSPP/linux/issues/78
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH][next] tw89: core.h: Replace zero-length array with flexible-array member
2022-02-16 20:35 ` Kees Cook
@ 2022-02-17 0:25 ` Pkshih
0 siblings, 0 replies; 6+ messages in thread
From: Pkshih @ 2022-02-17 0:25 UTC (permalink / raw)
To: Kees Cook, Gustavo A. R. Silva
Cc: Kalle Valo, David S. Miller, Jakub Kicinski, linux-wireless,
netdev, linux-kernel, linux-hardening
> -----Original Message-----
> From: Kees Cook <keescook@chromium.org>
> Sent: Thursday, February 17, 2022 4:36 AM
> To: Gustavo A. R. Silva <gustavoars@kernel.org>
> Cc: Pkshih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>; David S. Miller <davem@davemloft.net>;
> Jakub Kicinski <kuba@kernel.org>; linux-wireless@vger.kernel.org; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-hardening@vger.kernel.org
> Subject: Re: [PATCH][next] tw89: core.h: Replace zero-length array with flexible-array member
>
> On Wed, Feb 16, 2022 at 01:50:47PM -0600, Gustavo A. R. Silva wrote:
> > There is a regular need in the kernel to provide a way to declare
> > having a dynamically sized set of trailing elements in a structure.
> > Kernel code should always use “flexible array members”[1] for these
> > cases. The older style of one-element or zero-length arrays should
> > no longer be used[2].
> >
> > [1] https://en.wikipedia.org/wiki/Flexible_array_member
> > [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
> >
> > Link: https://github.com/KSPP/linux/issues/78
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
--
Ping-Ke
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][next] tw89: core.h: Replace zero-length array with flexible-array member
2022-02-16 19:50 [PATCH][next] tw89: core.h: Replace zero-length array with flexible-array member Gustavo A. R. Silva
2022-02-16 20:35 ` Kees Cook
@ 2022-02-17 2:42 ` Jakub Kicinski
2022-02-17 10:06 ` Kalle Valo
2022-02-21 9:01 ` [next] rtw89: " Kalle Valo
2 siblings, 1 reply; 6+ messages in thread
From: Jakub Kicinski @ 2022-02-17 2:42 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Ping-Ke Shih, Kalle Valo, David S. Miller, linux-wireless,
netdev, linux-kernel, linux-hardening
On Wed, 16 Feb 2022 13:50:47 -0600 Gustavo A. R. Silva wrote:
> There is a regular need in the kernel to provide a way to declare
> having a dynamically sized set of trailing elements in a structure.
> Kernel code should always use “flexible array members”[1] for these
> cases. The older style of one-element or zero-length arrays should
> no longer be used[2].
>
> [1] https://en.wikipedia.org/wiki/Flexible_array_member
> [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
>
> Link: https://github.com/KSPP/linux/issues/78
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
The subject is off.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][next] tw89: core.h: Replace zero-length array with flexible-array member
2022-02-17 2:42 ` Jakub Kicinski
@ 2022-02-17 10:06 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2022-02-17 10:06 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Gustavo A. R. Silva, Ping-Ke Shih, David S. Miller,
linux-wireless, netdev, linux-kernel, linux-hardening
Jakub Kicinski <kuba@kernel.org> writes:
> On Wed, 16 Feb 2022 13:50:47 -0600 Gustavo A. R. Silva wrote:
>> There is a regular need in the kernel to provide a way to declare
>> having a dynamically sized set of trailing elements in a structure.
>> Kernel code should always use “flexible array members”[1] for these
>> cases. The older style of one-element or zero-length arrays should
>> no longer be used[2].
>>
>> [1] https://en.wikipedia.org/wiki/Flexible_array_member
>> [2]
>> https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
>>
>> Link: https://github.com/KSPP/linux/issues/78
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> The subject is off.
I can fix that during commit.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [next] rtw89: core.h: Replace zero-length array with flexible-array member
2022-02-16 19:50 [PATCH][next] tw89: core.h: Replace zero-length array with flexible-array member Gustavo A. R. Silva
2022-02-16 20:35 ` Kees Cook
2022-02-17 2:42 ` Jakub Kicinski
@ 2022-02-21 9:01 ` Kalle Valo
2 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2022-02-21 9:01 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Ping-Ke Shih, David S. Miller, Jakub Kicinski, linux-wireless,
netdev, linux-kernel, Gustavo A. R. Silva, linux-hardening
"Gustavo A. R. Silva" <gustavoars@kernel.org> wrote:
> There is a regular need in the kernel to provide a way to declare
> having a dynamically sized set of trailing elements in a structure.
> Kernel code should always use “flexible array members”[1] for these
> cases. The older style of one-element or zero-length arrays should
> no longer be used[2].
>
> [1] https://en.wikipedia.org/wiki/Flexible_array_member
> [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
>
> Link: https://github.com/KSPP/linux/issues/78
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-next.git, thanks.
2e2f63a19b0a rtw89: core.h: Replace zero-length array with flexible-array member
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220216195047.GA904198@embeddedor/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-21 9:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16 19:50 [PATCH][next] tw89: core.h: Replace zero-length array with flexible-array member Gustavo A. R. Silva
2022-02-16 20:35 ` Kees Cook
2022-02-17 0:25 ` Pkshih
2022-02-17 2:42 ` Jakub Kicinski
2022-02-17 10:06 ` Kalle Valo
2022-02-21 9:01 ` [next] rtw89: " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).