From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC7BC433F5 for ; Wed, 23 Feb 2022 08:58:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231680AbiBWI6i (ORCPT ); Wed, 23 Feb 2022 03:58:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbiBWI6i (ORCPT ); Wed, 23 Feb 2022 03:58:38 -0500 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFB357463A; Wed, 23 Feb 2022 00:58:10 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=ashimida@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0V5Hmy0a_1645606685; Received: from 192.168.193.152(mailfrom:ashimida@linux.alibaba.com fp:SMTPD_---0V5Hmy0a_1645606685) by smtp.aliyun-inc.com(127.0.0.1); Wed, 23 Feb 2022 16:58:06 +0800 Message-ID: <887572c7-b508-ca51-6cd5-54a2c9ecaa75@linux.alibaba.com> Date: Wed, 23 Feb 2022 00:58:05 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH] [PATCH] AARCH64: Add gcc Shadow Call Stack support Content-Language: en-US To: Miguel Ojeda , Guenter Roeck Cc: Nathan Chancellor , Catalin Marinas , Will Deacon , Nick Desaulniers , Kees Cook , Masahiro Yamada , Thomas Gleixner , Andrew Morton , Mark Rutland , Sami Tolvanen , Nicholas Piggin , Masami Hiramatsu , Miguel Ojeda , Luc Van Oostenryck , Marco Elver , linux-kernel , Linux ARM , llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20220222095736.24898-1-ashimida@linux.alibaba.com> From: Dan Li In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On 2/22/22 08:59, Miguel Ojeda wrote: > On Tue, Feb 22, 2022 at 5:48 PM Guenter Roeck wrote: >> >> The point here, I think, is to list the minimum gcc version. >> It is going to be a long time until gcc 12.0 is the minimum version, >> so I think it makes sense to list the minimum version number for >> each compiler here. > > Yeah, please list the minimum version (ideally `>=` instead of `>`, > with the actual version where it first appeared). It makes it easy to > then remove things that are not needed anymore when the minimum GCC > version is upgraded. > Got it, I'll use "gcc >= 12.0.0" in the next patch. Thanks, Dan.