From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15F8AC433B4 for ; Tue, 20 Apr 2021 20:10:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE452613C8 for ; Tue, 20 Apr 2021 20:10:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233807AbhDTULA (ORCPT ); Tue, 20 Apr 2021 16:11:00 -0400 Received: from gateway31.websitewelcome.com ([192.185.144.219]:44297 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233544AbhDTULA (ORCPT ); Tue, 20 Apr 2021 16:11:00 -0400 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id E29D45FA13 for ; Tue, 20 Apr 2021 15:09:11 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id YwgJlhROab8LyYwgJljL6e; Tue, 20 Apr 2021 15:09:11 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9B0yy04ZlX+XOpLtOLXLro5YGBYuU/g5MJ8vNg1SATk=; b=sfQrpe/V49WFyWapAHyeNonLEs IQtiGdBsz1nayl5zAaBmTFNH9Gsn20i3jJyKYrwQ7R5K5FsB7S+9U5P0ItXPx+pgMTZ+wpRHbJB+S eJSICvpeXrnpD9oLdaMBjpt/+pI0bb6unv+UTyQrDoEwC/odcuk69BelG3mARa17m0j9j3xiH0fsb c3F9CqEYSqbs96tI+zS0KjvdxYiFf2Re3bqAuAzSV2HqT6YpMXAGfWWJzBT2QWP5HY8/6c/GIxSbQ SQ3fdD0axH2ZkBkK7m7dq9E7KmpFY0LQf5k+IevIxvzEQwakrD29OWiIrNW5SPk8EtDyET9HByvSL BK04cAXg==; Received: from 187-162-31-110.static.axtel.net ([187.162.31.110]:48936 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lYwgG-002d36-BK; Tue, 20 Apr 2021 15:09:08 -0500 Subject: Re: [PATCH RESEND][next] sctp: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" , Vlad Yasevich , Neil Horman , Marcelo Ricardo Leitner , "David S. Miller" , Jakub Kicinski Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20210305090717.GA139387@embeddedor> From: "Gustavo A. R. Silva" Message-ID: <91fcca0d-c986-f88e-4a0d-4590de6a5985@embeddedor.com> Date: Tue, 20 Apr 2021 15:09:24 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210305090717.GA139387@embeddedor> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.31.110 X-Source-L: No X-Exim-ID: 1lYwgG-002d36-BK X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-31-110.static.axtel.net ([192.168.15.8]) [187.162.31.110]:48936 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 37 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:07, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > of warnings by explicitly adding a break statement and replacing a > comment with a goto statement instead of letting the code fall through > to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva > --- > net/sctp/input.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/sctp/input.c b/net/sctp/input.c > index d508f6f3dd08..5ceaf75105ba 100644 > --- a/net/sctp/input.c > +++ b/net/sctp/input.c > @@ -633,7 +633,7 @@ int sctp_v4_err(struct sk_buff *skb, __u32 info) > break; > case ICMP_REDIRECT: > sctp_icmp_redirect(sk, transport, skb); > - /* Fall through to out_unlock. */ > + goto out_unlock; > default: > goto out_unlock; > } > @@ -1236,6 +1236,7 @@ static struct sctp_association *__sctp_rcv_walk_lookup(struct net *net, > net, ch, laddr, > sctp_hdr(skb)->source, > transportp); > + break; > default: > break; > } >