* [PATCH RESEND][next] qlcnic: Fix fall-through warnings for Clang
@ 2021-03-05 9:17 Gustavo A. R. Silva
2021-04-20 20:27 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05 9:17 UTC (permalink / raw)
To: Shahed Shaikh, Manish Chopra, David S. Miller, Jakub Kicinski
Cc: GR-Linux-NIC-Dev, netdev, linux-kernel, Gustavo A. R. Silva,
linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding a break and a goto statements instead of
just letting the code fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 1 +
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
index bdf15d2a6431..af4c516a9e7c 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
@@ -1390,6 +1390,7 @@ static int qlcnic_process_rcv_ring(struct qlcnic_host_sds_ring *sds_ring, int ma
break;
case QLCNIC_RESPONSE_DESC:
qlcnic_handle_fw_message(desc_cnt, consumer, sds_ring);
+ goto skip;
default:
goto skip;
}
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index 96b947fde646..8966f1bcda77 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -3455,6 +3455,7 @@ qlcnic_fwinit_work(struct work_struct *work)
adapter->fw_wait_cnt = 0;
return;
}
+ break;
case QLCNIC_DEV_FAILED:
break;
default:
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND][next] qlcnic: Fix fall-through warnings for Clang
2021-03-05 9:17 [PATCH RESEND][next] qlcnic: Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2021-04-20 20:27 ` Gustavo A. R. Silva
2021-05-18 0:25 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-04-20 20:27 UTC (permalink / raw)
To: Gustavo A. R. Silva, Shahed Shaikh, Manish Chopra,
David S. Miller, Jakub Kicinski
Cc: GR-Linux-NIC-Dev, netdev, linux-kernel, linux-hardening
Hi all,
Friendly ping: who can take this, please?
Thanks
--
Gustavo
On 3/5/21 03:17, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding a break and a goto statements instead of
> just letting the code fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 1 +
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
> index bdf15d2a6431..af4c516a9e7c 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
> @@ -1390,6 +1390,7 @@ static int qlcnic_process_rcv_ring(struct qlcnic_host_sds_ring *sds_ring, int ma
> break;
> case QLCNIC_RESPONSE_DESC:
> qlcnic_handle_fw_message(desc_cnt, consumer, sds_ring);
> + goto skip;
> default:
> goto skip;
> }
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> index 96b947fde646..8966f1bcda77 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> @@ -3455,6 +3455,7 @@ qlcnic_fwinit_work(struct work_struct *work)
> adapter->fw_wait_cnt = 0;
> return;
> }
> + break;
> case QLCNIC_DEV_FAILED:
> break;
> default:
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND][next] qlcnic: Fix fall-through warnings for Clang
2021-04-20 20:27 ` Gustavo A. R. Silva
@ 2021-05-18 0:25 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-05-18 0:25 UTC (permalink / raw)
To: Gustavo A. R. Silva, Shahed Shaikh, Manish Chopra,
David S. Miller, Jakub Kicinski
Cc: GR-Linux-NIC-Dev, netdev, linux-kernel, linux-hardening
Hi,
I'm taking this in my -next[1] branch for v5.14.
Thanks
--
Gustavo
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp
On 4/20/21 15:27, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping: who can take this, please?
>
> Thanks
> --
> Gustavo
>
> On 3/5/21 03:17, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
>> warnings by explicitly adding a break and a goto statements instead of
>> just letting the code fall through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>> ---
>> drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 1 +
>> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
>> index bdf15d2a6431..af4c516a9e7c 100644
>> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
>> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
>> @@ -1390,6 +1390,7 @@ static int qlcnic_process_rcv_ring(struct qlcnic_host_sds_ring *sds_ring, int ma
>> break;
>> case QLCNIC_RESPONSE_DESC:
>> qlcnic_handle_fw_message(desc_cnt, consumer, sds_ring);
>> + goto skip;
>> default:
>> goto skip;
>> }
>> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>> index 96b947fde646..8966f1bcda77 100644
>> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>> @@ -3455,6 +3455,7 @@ qlcnic_fwinit_work(struct work_struct *work)
>> adapter->fw_wait_cnt = 0;
>> return;
>> }
>> + break;
>> case QLCNIC_DEV_FAILED:
>> break;
>> default:
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-18 0:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 9:17 [PATCH RESEND][next] qlcnic: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-04-20 20:27 ` Gustavo A. R. Silva
2021-05-18 0:25 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).