From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Kees Cook <keescook@chromium.org>,
Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: linux-hardening@vger.kernel.org, error27@gmail.com,
gustavoars@kernel.org, Bryan Tan <bryantan@vmware.com>,
Vishnu Dasa <vdasa@vmware.com>,
VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, vegard.nossum@oracle.com,
darren.kenny@oracle.com, syzkaller <syzkaller@googlegroups.com>
Subject: Re: [PATCH v2 2/2] VMCI: Fix memcpy() run-time warning in dg_dispatch_as_host()
Date: Mon, 8 Jan 2024 20:05:38 -0600 [thread overview]
Message-ID: <9c742547-0021-464b-b7a8-7af46b0a4afa@embeddedor.com> (raw)
In-Reply-To: <202401081430.9DAB37B46@keescook>
On 1/8/24 16:37, Kees Cook wrote:
> On Fri, Jan 05, 2024 at 08:40:00AM -0800, Harshit Mogalapalli wrote:
>> Syzkaller hit 'WARNING in dg_dispatch_as_host' bug.
>>
>> memcpy: detected field-spanning write (size 56) of single field "&dg_info->msg"
>> at drivers/misc/vmw_vmci/vmci_datagram.c:237 (size 24)
>>
>> WARNING: CPU: 0 PID: 1555 at drivers/misc/vmw_vmci/vmci_datagram.c:237
>> dg_dispatch_as_host+0x88e/0xa60 drivers/misc/vmw_vmci/vmci_datagram.c:237
>>
>> Some code commentry, based on my understanding:
>>
>> 544 #define VMCI_DG_SIZE(_dg) (VMCI_DG_HEADERSIZE + (size_t)(_dg)->payload_size)
>> /// This is 24 + payload_size
>>
>> memcpy(&dg_info->msg, dg, dg_size);
>> Destination = dg_info->msg ---> this is a 24 byte
>> structure(struct vmci_datagram)
>> Source = dg --> this is a 24 byte structure (struct vmci_datagram)
>> Size = dg_size = 24 + payload_size
>>
>> {payload_size = 56-24 =32} -- Syzkaller managed to set payload_size to 32.
>>
>> 35 struct delayed_datagram_info {
>> 36 struct datagram_entry *entry;
>> 37 struct work_struct work;
>> 38 bool in_dg_host_queue;
>> 39 /* msg and msg_payload must be together. */
>> 40 struct vmci_datagram msg;
>> 41 u8 msg_payload[];
>> 42 };
>>
>> So those extra bytes of payload are copied into msg_payload[], a run time
>> warning is seen while fuzzing with Syzkaller.
>>
>> One possible way to fix the warning is to split the memcpy() into
>> two parts -- one -- direct assignment of msg and second taking care of payload.
>>
>> Gustavo quoted:
>> "Under FORTIFY_SOURCE we should not copy data across multiple members
>> in a structure."
>>
>> Reported-by: syzkaller <syzkaller@googlegroups.com>
>> Suggested-by: Vegard Nossum <vegard.nossum@oracle.com>
>> Suggested-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
>
> Thanks for getting this fixed!
>
> Yeah, it's a "false positive" in the sense that the code was expecting
It's a false positive _bug_, and a legitimate _warning_ coming from fortified
memcpy().
> to write into msg_payload. The warning is triggered because of the write
> across the flex array boundary, which trips a bug in GCC and Clang,
> which we're forced to work around.
The warning is triggered because of a write beyond the boundaries of
`dg_info->msg`. It's not directly related to the fact that there is a
flexible-array member following `dg_info->msg`.
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101832 (fixed in GCC 14+)
> (not yet fixed in Clang)
This issue is not related to the compiler bugs mentioned above.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
Thanks!
--
Gustavo
next prev parent reply other threads:[~2024-01-09 2:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 16:39 [PATCH v2 1/2] VMCI: Use struct_size() in kmalloc() Harshit Mogalapalli
2024-01-05 16:40 ` [PATCH v2 2/2] VMCI: Fix memcpy() run-time warning in dg_dispatch_as_host() Harshit Mogalapalli
2024-01-05 17:11 ` Gustavo A. R. Silva
2024-01-08 7:33 ` Dan Carpenter
2024-01-08 17:03 ` Gustavo A. R. Silva
2024-01-08 17:31 ` Harshit Mogalapalli
2024-01-08 17:38 ` Gustavo A. R. Silva
2024-01-08 18:36 ` Dan Carpenter
2024-01-08 19:21 ` Gustavo A. R. Silva
2024-01-08 22:37 ` Kees Cook
2024-01-09 2:05 ` Gustavo A. R. Silva [this message]
2024-01-09 9:07 ` Dan Carpenter
2024-01-09 12:31 ` Gustavo A. R. Silva
2024-01-09 13:22 ` Dan Carpenter
2024-01-09 14:35 ` Gustavo A. R. Silva
2024-01-11 0:03 ` Kees Cook
2024-01-11 7:15 ` Dan Carpenter
2024-01-11 18:13 ` Kees Cook
2024-01-12 5:35 ` Dan Carpenter
2024-01-11 12:53 ` kovalev
2024-02-16 7:35 ` Harshit Mogalapalli
2024-01-05 16:57 ` [PATCH v2 1/2] VMCI: Use struct_size() in kmalloc() Gustavo A. R. Silva
2024-01-08 22:28 ` Kees Cook
2024-02-01 18:06 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c742547-0021-464b-b7a8-7af46b0a4afa@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=arnd@arndb.de \
--cc=bryantan@vmware.com \
--cc=darren.kenny@oracle.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=syzkaller@googlegroups.com \
--cc=vdasa@vmware.com \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).