From: Azeem Shaikh <azeemshaikh38@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
linux-hardening@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NFS: Prefer strscpy over strlcpy calls
Date: Mon, 22 May 2023 12:19:36 -0400 [thread overview]
Message-ID: <CADmuW3X1M_j2j=nsx2hM0YO1NeQsrOeb2Z1GOoMAOHCcPozF=A@mail.gmail.com> (raw)
In-Reply-To: <202305161403.15ED4EC@keescook>
> > ---
> > Note to reviewers: the one case where this patch would modify existing behavior
> > is when strlen(src)==destlen==0. Current behavior returns 0, with this patch it
> > would return -1.
> >
> > Not sure what the implication of this updated behavior would be,
> > so bringing it to your attention.
>
> I'm not sure either, but I would prefer non-terminated strings produce
> an error, which this change does. :)
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
Friendly ping.
next prev parent reply other threads:[~2023-05-22 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 15:57 [PATCH] NFS: Prefer strscpy over strlcpy calls Azeem Shaikh
2023-05-16 21:04 ` Kees Cook
2023-05-22 16:19 ` Azeem Shaikh [this message]
2023-05-22 19:39 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADmuW3X1M_j2j=nsx2hM0YO1NeQsrOeb2Z1GOoMAOHCcPozF=A@mail.gmail.com' \
--to=azeemshaikh38@gmail.com \
--cc=anna@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).