From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 782EAC433EF for ; Wed, 29 Sep 2021 20:59:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56784611EF for ; Wed, 29 Sep 2021 20:59:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343678AbhI2VBF (ORCPT ); Wed, 29 Sep 2021 17:01:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344514AbhI2VBD (ORCPT ); Wed, 29 Sep 2021 17:01:03 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94BF5C061766 for ; Wed, 29 Sep 2021 13:59:21 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id m21so3930772pgu.13 for ; Wed, 29 Sep 2021 13:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NDTUGfYj9oi0gUXH9XqZgjp5PU9RCsTIj0stetjLRiw=; b=OK0JjRy2JCSehREjoq9JQ+sAEQDjEmiCNclsNGEfzKeacJDQfaDp2JmKrUgSGjO2d9 ns1lg77daDtxbYsaKQkX3+M1HOM4Nc46FNBRzHRGFxRCmbRlyXZo0pRIuNH5bhCIF/pM 0SWUD2Jo+DrQpARjUMUrZ3fmgBTbcnX3VCWXrpxL2y4gbasZEVzuBvAdc9/8mdNaq6eH gJuLNNf6dKm++kI0RDdVLxVTvgvStc0ye6xzGRbEs3CkaJ3mh8A+mB3piVyCWRvJPipk yf6yhO+/m4JLbuy1OZmq/yvMXVbwnzjuqseB+4uVsZ20lDxZXIqWcN9JBsEHowLH/KDN cRDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NDTUGfYj9oi0gUXH9XqZgjp5PU9RCsTIj0stetjLRiw=; b=OAZilBbzTnFY747WVq2SQd3ZRnZO+IFNwAdREVLMt1fDYvJmSdwcLKaeJOFjglnMUE 9NGFN05T5vg/rgrjWMtLp/mWPg9MLOVGSh3A8DyynKRQMHJHVhI8gdvnnmoSzDa/eN/T 9cdrBBj6z2SYe0T7G2BnyOBaKf2Ozd/XsSLUq7NuDcK/Fnyqn8E4YMCdF+wP3d6ESxLJ kpHPLf7dNyw2xpCYPA38cQIaByZouyKqtdSZBQ0FQbEwTBnsdw9ytMgLAxyxzz8ZdSxo sppruYP52hRs01gw0krV4Qlydd+/xV3DzG1su+/kNxG5janT83j2qOQTqSibKKdJ21kk FtDQ== X-Gm-Message-State: AOAM531za56CrtNK4QAGjRO8cN0rcYH/h1WJiRp73uNMotli9JmyX0xy c7a6ljYudc4U5PcLp3lnDSP7sidyldSpkaKSPkBl3w== X-Google-Smtp-Source: ABdhPJwl2RK2Jn+5k+99JJpFvjDAl4+N1WDibTWsaaDTXV5XVD2P6HI4SLPTLrWY6ZrdxfKHD+AtTNdO0nf0abSvz+g= X-Received: by 2002:a63:1550:: with SMTP id 16mr1691275pgv.442.1632949160817; Wed, 29 Sep 2021 13:59:20 -0700 (PDT) MIME-Version: 1.0 References: <20210917061104.2680133-1-brendanhiggins@google.com> <20210917061104.2680133-6-brendanhiggins@google.com> <202109170856.8DDB49112D@keescook> In-Reply-To: From: Brendan Higgins Date: Wed, 29 Sep 2021 13:59:09 -0700 Message-ID: Subject: Re: [PATCH v1 5/6] mmc: sdhci-of-aspeed: build kunit tests without structleak plugin To: Linus Torvalds Cc: Kees Cook , Shuah Khan , David Gow , Arnd Bergmann , Rafael Wysocki , Jonathan Cameron , Lars-Peter Clausen , Ulf Hansson , andreas.noever@gmail.com, michael.jamet@intel.com, Mika Westerberg , yehezkelshb@gmail.com, Masahiro Yamada , Michal Marek , Nick Desaulniers , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Kernel Mailing List , Greg Kroah-Hartman , linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-usb@vger.kernel.org, linux-hardening@vger.kernel.org, Linux Kbuild mailing list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Fri, Sep 17, 2021 at 11:40 AM Linus Torvalds wrote: > > On Fri, Sep 17, 2021 at 8:57 AM Kees Cook wrote: > > > > This isn't a stand-alone test object, so I'm less excited about > > disabling STRUCTLEAK here. > > Yeah, please don't do this for things that aren't pure tests. You're > now disabling security measures (even if I hate the gcc plugins and > hope they will go away). Oh, whoops, yeah, I shouldn't do that. I am just going to drop this patch entirely, as I wasn't able to reproduce the stack frame size issue on qemu anyway (as I mentioned on the cover letter). Thanks for catching this. Sorry!