From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9B47C2D0E4 for ; Mon, 23 Nov 2020 13:16:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6ACF720773 for ; Mon, 23 Nov 2020 13:16:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733201AbgKWMoS (ORCPT ); Mon, 23 Nov 2020 07:44:18 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:39786 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733192AbgKWMoO (ORCPT ); Mon, 23 Nov 2020 07:44:14 -0500 Received: by mail-oi1-f196.google.com with SMTP id f11so19526227oij.6; Mon, 23 Nov 2020 04:44:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KDOKs+LWZAEtXD019s6TRQMEMxS8eHoo7U7CRierk2c=; b=YiS9//Z3mUEXyXBHc5XXGo5MPnpXdETZZOdyRPQ9C43jYrW/ibph6ellZbdHMhFL3i h8lXNZAupaNggopbIo0c2dpXtBotA3aD/U+jWpPOkvdmjnxoBseCd0lhcd8PpAx4/0Gl 1BHaRTOcgiMq/Ry8jdzGTQj45tACjEEuuu70dbuPCtHI6UYJB6Azfmgxd+r4ZnCPBaz+ /fmarJZzNu40IuwaekXLz+kkzow1hLbtnHn9Dz0GfLXdGLsECcKk9rTzcB0RmEhP8sXn uKJCkmBmulvynLHe5vu5Y4CSgzCdbaUFqSoAV9iU1E2qXbYhQrWntinFzNvd/DlgttH7 v8og== X-Gm-Message-State: AOAM533zBaiTAc68b34yTSmtlLyfHsc9klGzctg48Psb8033B3wESXNF N6YCAULHCc+gjOURwOEb2UxeaEAHbnbOvVfdrZTehS8C X-Google-Smtp-Source: ABdhPJxlUELhJljvvZ8/43jcv4X43NR3x85e0tSj0AnNyAy02FR5lVITsJI179Pshd4f9slg0NLuAJGyfQb8NdS9GSo= X-Received: by 2002:aca:da02:: with SMTP id r2mr10052427oig.157.1606135454539; Mon, 23 Nov 2020 04:44:14 -0800 (PST) MIME-Version: 1.0 References: <1e081610a68043fe89ca5a2795963cbee6d5fc0f.1605896059.git.gustavoars@kernel.org> In-Reply-To: <1e081610a68043fe89ca5a2795963cbee6d5fc0f.1605896059.git.gustavoars@kernel.org> From: "Rafael J. Wysocki" Date: Mon, 23 Nov 2020 12:43:57 +0100 Message-ID: Subject: Re: [PATCH 064/141] ACPI: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" Cc: "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Linux Kernel Mailing List , linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Fri, Nov 20, 2020 at 7:34 PM Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/acpi/sbshc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/acpi/sbshc.c b/drivers/acpi/sbshc.c > index 53c2862c4c75..0b3de0e63633 100644 > --- a/drivers/acpi/sbshc.c > +++ b/drivers/acpi/sbshc.c > @@ -231,6 +231,7 @@ static int smbus_alarm(void *context) > case ACPI_SBS_BATTERY: > acpi_os_execute(OSL_NOTIFY_HANDLER, > acpi_smbus_callback, hc); > + break; > default:; Why don't you simply drop the default case below (it's empty anyway)? > } > mutex_unlock(&hc->lock); > -- > 2.27.0 >