linux-hardening.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Nicolas Schier <n.schier@avm.de>,
	sparclinux <sparclinux@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH] sparc: Add missing "FORCE" target when using if_changed
Date: Wed, 6 Oct 2021 21:53:18 +0900	[thread overview]
Message-ID: <CAK7LNASWgdULqBJMQMkoy=mXtAj_xxcYXXXi0wYojMkWW4ktGA@mail.gmail.com> (raw)
In-Reply-To: <202110052144.25B30F2D4F@keescook>

On Wed, Oct 6, 2021 at 1:45 PM Kees Cook <keescook@chromium.org> wrote:
>
> On Fri, Sep 24, 2021 at 06:38:56AM +0200, Nicolas Schier wrote:
> > On Thu, Sep 23, 2021 at 02:54:18PM -0700, Kees Cook wrote:
> > > Fix observed warning:
> > >
> > >     /builds/linux/arch/sparc/boot/Makefile:35: FORCE prerequisite is missing
> > >
> > > Fixes: e1f86d7b4b2a5213 ("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and filechk")
> > > Cc: "David S. Miller" <davem@davemloft.net>
> > > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > > Cc: sparclinux@vger.kernel.org
> > > Signed-off-by: Kees Cook <keescook@chromium.org>
> >
> > Acked-by: Nicolas Schier <n.schier@avm.de>
>
> Thanks!
>
> Masahiro, are you able to add this to your kbuild tree?

Sure, applied to linux-kbuild. Thanks.


> -Kees
>
> >
> > > ---
> > > I'm not sure if this should go via sparc or via kbuild. :)
> > > ---
> > >  arch/sparc/boot/Makefile | 8 ++++----
> > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/arch/sparc/boot/Makefile b/arch/sparc/boot/Makefile
> > > index 849236d4eca4..45e5c76d449e 100644
> > > --- a/arch/sparc/boot/Makefile
> > > +++ b/arch/sparc/boot/Makefile
> > > @@ -22,7 +22,7 @@ ifeq ($(CONFIG_SPARC64),y)
> > >
> > >  # Actual linking
> > >
> > > -$(obj)/zImage: $(obj)/image
> > > +$(obj)/zImage: $(obj)/image FORCE
> > >     $(call if_changed,gzip)
> > >     @echo '  kernel: $@ is ready'
> > >
> > > @@ -31,7 +31,7 @@ $(obj)/vmlinux.aout: vmlinux FORCE
> > >     @echo '  kernel: $@ is ready'
> > >  else
> > >
> > > -$(obj)/zImage: $(obj)/image
> > > +$(obj)/zImage: $(obj)/image FORCE
> > >     $(call if_changed,strip)
> > >     @echo '  kernel: $@ is ready'
> > >
> > > @@ -44,7 +44,7 @@ OBJCOPYFLAGS_image.bin := -S -O binary -R .note -R .comment
> > >  $(obj)/image.bin: $(obj)/image FORCE
> > >     $(call if_changed,objcopy)
> > >
> > > -$(obj)/image.gz: $(obj)/image.bin
> > > +$(obj)/image.gz: $(obj)/image.bin FORCE
> > >     $(call if_changed,gzip)
> > >
> > >  UIMAGE_LOADADDR = $(CONFIG_UBOOT_LOAD_ADDR)
> > > @@ -56,7 +56,7 @@ quiet_cmd_uimage.o = UIMAGE.O $@
> > >                       -r -b binary $@ -o $@.o
> > >
> > >  targets += uImage
> > > -$(obj)/uImage: $(obj)/image.gz
> > > +$(obj)/uImage: $(obj)/image.gz FORCE
> > >     $(call if_changed,uimage)
> > >     $(call if_changed,uimage.o)
> > >     @echo '  Image $@ is ready'
> > > --
> > > 2.30.2
> > >
>
> --
> Kees Cook



-- 
Best Regards
Masahiro Yamada

      reply	other threads:[~2021-10-06 12:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 21:54 Kees Cook
2021-09-24  4:38 ` Nicolas Schier
2021-10-06  4:45   ` Kees Cook
2021-10-06 12:53     ` Masahiro Yamada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNASWgdULqBJMQMkoy=mXtAj_xxcYXXXi0wYojMkWW4ktGA@mail.gmail.com' \
    --to=masahiroy@kernel.org \
    --cc=davem@davemloft.net \
    --cc=keescook@chromium.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=n.schier@avm.de \
    --cc=sparclinux@vger.kernel.org \
    --subject='Re: [PATCH] sparc: Add missing "FORCE" target when using if_changed' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).