From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB1A8C433F5 for ; Thu, 3 Feb 2022 22:13:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239114AbiBCWNr (ORCPT ); Thu, 3 Feb 2022 17:13:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232640AbiBCWNq (ORCPT ); Thu, 3 Feb 2022 17:13:46 -0500 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D935C061714 for ; Thu, 3 Feb 2022 14:13:46 -0800 (PST) Received: by mail-lj1-x236.google.com with SMTP id z20so5947827ljo.6 for ; Thu, 03 Feb 2022 14:13:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2xJKejqFUEH0gH02bsrJyrmiS9uC9eYI5/u6Jxv0S8E=; b=H24z7FjJDol5wBZEbnN2Imdyd1onGd0cFpHlfJZfyL+uWUtNi2aoFXif9gUr+4s3Xv uBmskidnVWURLL+YtWHTjHZ9PJG9hKcRd7yQhsPw58FBd4qf0Q4eTR/0/1f4tOtdnCu1 fDPqQqRoSiBLnGmelyqJmyFNGGvecWyqTLD4PXP1wAafPBiLwFGWOmNe+uuU6wMO8cfJ MRPioqayInupF70/CODAACEA0JvTFoJTv+OByl6ZVBfaxCQpBYUO/HI2TkIH1YBncuQK Lzw6UWJ7iq3T2kAX32oz66qtHCL6s7tKSB94chdxTr8WF7WpolWrLPftMc0su3IMkMdb /jUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2xJKejqFUEH0gH02bsrJyrmiS9uC9eYI5/u6Jxv0S8E=; b=L8xwjA6IUQeoRcihCL7/suw+IM6bqkoPsSsUV5apHAaOisJdvOwt8H/qB4wTNXu3RP 9Nyzjl3kYxy7xEL1HZ3rQrOB+vPfNvybqzV3TtBMDzRVjpJSDqBOKld+z2AHkcJuoe1t OxYFUpwycEXmLGM0wI3Lkq3rFjbzf8o4b6gpctqEw6KOlRWAObdL4eZ+WIBphgtRA5wi fJtqlr2cHk37Pjk2BVS7bipzLhT4fZMxXp6jrYREWCER2b2KrIY7xVGX9EJOhEVOoxd8 rYBZnvqEPd9RtOA55Zc0LM/BMT26oJBE9IwfNh2x/gKDEwbShp/DTeBITWJVf9ZXKr0i nUKg== X-Gm-Message-State: AOAM530HV1CD5oOvKebZFtFUQek9zxgwfkHbORWOdqpz9pB4jOPyjjuo E6DGrCi4fyqUMEp777hCvkhFckoPl7BxKPgX9ygyJw== X-Google-Smtp-Source: ABdhPJwukk4FfgGCE9DXGX12jyqxMhXq20QnpHOQ5CsAHRtiMZ0ck8ImUh9oBxHNeO9V4ehDak2Z2QOHbbWezu5b8SI= X-Received: by 2002:a05:651c:1305:: with SMTP id u5mr27111lja.339.1643926424857; Thu, 03 Feb 2022 14:13:44 -0800 (PST) MIME-Version: 1.0 References: <20220202003033.704951-1-keescook@chromium.org> <20220202003033.704951-5-keescook@chromium.org> In-Reply-To: <20220202003033.704951-5-keescook@chromium.org> From: Nick Desaulniers Date: Thu, 3 Feb 2022 14:13:33 -0800 Message-ID: Subject: Re: [PATCH 4/4 v5] fortify: Add Clang support To: Kees Cook Cc: Miguel Ojeda , Nathan Chancellor , George Burgess IV , llvm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-security-module@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Tue, Feb 1, 2022 at 4:30 PM Kees Cook wrote: > > diff --git a/include/linux/fortify-string.h b/include/linux/fortify-string.h > index c45159dbdaa1..5482536d3197 100644 > --- a/include/linux/fortify-string.h > +++ b/include/linux/fortify-string.h > @@ -2,7 +2,9 @@ > #ifndef _LINUX_FORTIFY_STRING_H_ > #define _LINUX_FORTIFY_STRING_H_ > > -#define __FORTIFY_INLINE extern __always_inline __attribute__((gnu_inline)) > +#include > + > +#define __FORTIFY_INLINE extern __always_inline __attribute__((gnu_inline)) __overloadable Sorry, I just noticed this line (already) uses a mix of open coding __attribute__ and not. Would you mind also please changing the open coded gnu_inline to simply __gnu_inline to make the entire line consistent? -- Thanks, ~Nick Desaulniers