* [PATCH] dma-buf/sw_sync: Replace all non-returning strlcpy with strscpy
@ 2023-05-23 2:19 Azeem Shaikh
2023-05-23 17:21 ` Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: Azeem Shaikh @ 2023-05-23 2:19 UTC (permalink / raw)
To: Sumit Semwal
Cc: linux-hardening, Azeem Shaikh, Gustavo Padovan, linux-media,
dri-devel, linux-kernel, Christian König, linaro-mm-sig
strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
---
drivers/dma-buf/sw_sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma-buf/sw_sync.c b/drivers/dma-buf/sw_sync.c
index 348b3a9170fa..63f0aeb66db6 100644
--- a/drivers/dma-buf/sw_sync.c
+++ b/drivers/dma-buf/sw_sync.c
@@ -85,7 +85,7 @@ static struct sync_timeline *sync_timeline_create(const char *name)
kref_init(&obj->kref);
obj->context = dma_fence_context_alloc(1);
- strlcpy(obj->name, name, sizeof(obj->name));
+ strscpy(obj->name, name, sizeof(obj->name));
obj->pt_tree = RB_ROOT;
INIT_LIST_HEAD(&obj->pt_list);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dma-buf/sw_sync: Replace all non-returning strlcpy with strscpy
2023-05-23 2:19 [PATCH] dma-buf/sw_sync: Replace all non-returning strlcpy with strscpy Azeem Shaikh
@ 2023-05-23 17:21 ` Kees Cook
2023-05-24 10:39 ` Sumit Semwal
0 siblings, 1 reply; 3+ messages in thread
From: Kees Cook @ 2023-05-23 17:21 UTC (permalink / raw)
To: Azeem Shaikh
Cc: Sumit Semwal, linux-hardening, Gustavo Padovan, linux-media,
dri-devel, linux-kernel, Christian König, linaro-mm-sig
On Tue, May 23, 2023 at 02:19:43AM +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dma-buf/sw_sync: Replace all non-returning strlcpy with strscpy
2023-05-23 17:21 ` Kees Cook
@ 2023-05-24 10:39 ` Sumit Semwal
0 siblings, 0 replies; 3+ messages in thread
From: Sumit Semwal @ 2023-05-24 10:39 UTC (permalink / raw)
To: Kees Cook
Cc: Azeem Shaikh, linux-hardening, Gustavo Padovan, linux-media,
dri-devel, linux-kernel, Christian König, linaro-mm-sig
Hello Azeem,
On Tue, 23 May 2023 at 22:52, Kees Cook <keescook@chromium.org> wrote:
>
> On Tue, May 23, 2023 at 02:19:43AM +0000, Azeem Shaikh wrote:
> > strlcpy() reads the entire source buffer first.
> > This read may exceed the destination size limit.
> > This is both inefficient and can lead to linear read
> > overflows if a source string is not NUL-terminated [1].
> > In an effort to remove strlcpy() completely [2], replace
> > strlcpy() here with strscpy().
> > No return values were used, so direct replacement is safe.
> >
> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> > [2] https://github.com/KSPP/linux/issues/89
Thank you for the patch; I'll queue it up.
> >
> > Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> --
> Kees Cook
Best,
Sumit.
--
Thanks and regards,
Sumit Semwal (he / him)
Tech Lead - LCG, Vertical Technologies
Linaro.org │ Open source software for ARM SoCs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-24 10:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-23 2:19 [PATCH] dma-buf/sw_sync: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-23 17:21 ` Kees Cook
2023-05-24 10:39 ` Sumit Semwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).