From: Greg KH <greg@kroah.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Kees Cook <keescook@chromium.org>, Len Baker <len.baker@gmx.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Mark Gross <mgross@linux.intel.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Prefer struct_size over open coded arithmetic
Date: Tue, 21 Sep 2021 17:45:41 +0200 [thread overview]
Message-ID: <YUn+Jfx9a+Ad1PsK@kroah.com> (raw)
In-Reply-To: <725ac392-642b-f57d-a286-d662eaa7d2a2@redhat.com>
On Tue, Sep 21, 2021 at 05:38:39PM +0200, Hans de Goede wrote:
> > All attributes for this driver are documented in Documentation/ABI/,
> > right? :)
>
> I'm not sure if all attributes are documented, but a lot of them
> (including all recently added ones) are documented in:
> Documentation/admin-guide/laptops/thinkpad-acpi.rst
They should also go into Documentation/ABI/ which is where sysfs files
are documented. We are working on tools that make parsing that easier,
so it would be good to keep them out of other random documentation
files whenever possible.
thanks,
greg k-h
next prev parent reply other threads:[~2021-09-21 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 15:05 [PATCH] platform/x86: thinkpad_acpi: Prefer struct_size over open coded arithmetic Len Baker
2021-09-20 5:58 ` Kees Cook
2021-09-21 13:46 ` Hans de Goede
2021-09-21 15:15 ` Greg KH
2021-09-21 15:38 ` Hans de Goede
2021-09-21 15:45 ` Greg KH [this message]
2021-09-25 10:40 ` Len Baker
2021-09-25 11:07 ` Greg KH
2021-09-25 13:33 ` Len Baker
2021-09-25 10:37 ` Len Baker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUn+Jfx9a+Ad1PsK@kroah.com \
--to=greg@kroah.com \
--cc=gustavoars@kernel.org \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=keescook@chromium.org \
--cc=len.baker@gmx.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).