From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C8DBC433EF for ; Wed, 2 Feb 2022 21:00:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245555AbiBBVAh (ORCPT ); Wed, 2 Feb 2022 16:00:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347368AbiBBVAh (ORCPT ); Wed, 2 Feb 2022 16:00:37 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9AACC061714; Wed, 2 Feb 2022 13:00:36 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id k18so840912wrg.11; Wed, 02 Feb 2022 13:00:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7OLSMx2LWSD7WsWcsdtwVZjsVIo2l+VXQLS4NW/dV3s=; b=eFLJLpFYFhHEofxCZUnGM50cphxmqi3TKrpCx+wcfetrsnhrHvhxr4vOJE7lYB9ZmT /elrTIKpSpkNXbqzxpdrXO2XLx2iEBrHH6xoHjDn+FbU4BKv6zKwNVN21CO+5xc3Q3Wf 8JKqHd/l5LZtx1UNv6k/TCXVkNZGL6v3a4kNko+voY2evS+gEb46C0pQ8OzSTtQs7eRe TnD0irmM9NqYkKyUvBgrOjQkKwLVCIrCjj2Ic8XUshmvRRkPVspCOJU2ZB0Y+O8xoyCf aEzKh+7sGJIbiGcAOtsLd45+WZlD/YL3t9Af/XVy46iejsEd+O6bWOu0HMrzUUxWtaaP TRYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7OLSMx2LWSD7WsWcsdtwVZjsVIo2l+VXQLS4NW/dV3s=; b=5tHP4qXhBSqYZV0QAAEf3J2QVGn/2kGyD/AasRlG/uQClMur1NKvQ179+75mPm9lJ6 SvjWkiMXi77NlkFXgdpItQHIJYzoKFxCj2DAq39ojLJo0+nXgGgxh7cPWPrdTJzCMhDz Dj9knsKOAHKNG6y8Pu65HNvH1/dzltQFuP3zsT1dcH3XBCdUVsxBghLMXMs/1BV6m9dg qOc90AnW5YJhvMhc1OAByftpV6BUhSpVIRlXFKLuF+Zi7rqSC9xyB92trWZV20bLwqli QAsGrxy4tdoRwIw2yyxQGnRfjMhFlRcMyRGCOhLbMuJH88pbcK4nCFCvgt1ow853AwLn 5/SA== X-Gm-Message-State: AOAM533gaI2oGgdc6xQDx8jijjWlmAcprRuuGn+axjuSVj1gkWekJJ53 77CsZxfMGMgpkSOodskLaw== X-Google-Smtp-Source: ABdhPJzyLbGClv9WiZEVQXQQzzJST75S7NNTUYTVo82rCjZ58Cit08TatZSRK6vgPtbzGK74oumIzA== X-Received: by 2002:a5d:494b:: with SMTP id r11mr27085816wrs.626.1643835635248; Wed, 02 Feb 2022 13:00:35 -0800 (PST) Received: from localhost.localdomain ([46.53.252.48]) by smtp.gmail.com with ESMTPSA id j19sm6464929wmq.17.2022.02.02.13.00.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Feb 2022 13:00:34 -0800 (PST) Date: Thu, 3 Feb 2022 00:00:32 +0300 From: Alexey Dobriyan To: Shuah Khan Cc: Kees Cook , Eric Biederman , Shuah Khan , linux-kselftest@vger.kernel.org, Ariadne Conill , Michael Kerrisk , Matthew Wilcox , Christian Brauner , Rich Felker , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] selftests/exec: Avoid future NULL argv execve warning Message-ID: References: <20220201000807.2453486-1-keescook@chromium.org> <7af32164-dbdf-26f1-1aaa-b720365f9743@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7af32164-dbdf-26f1-1aaa-b720365f9743@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Wed, Feb 02, 2022 at 10:38:57AM -0700, Shuah Khan wrote: > On 2/2/22 8:13 AM, Alexey Dobriyan wrote: > > On Mon, Jan 31, 2022 at 04:08:07PM -0800, Kees Cook wrote: > > > Build actual argv for launching recursion test to avoid future warning > > > about using an empty argv in execve(). > > > > > --- a/tools/testing/selftests/exec/recursion-depth.c > > > +++ b/tools/testing/selftests/exec/recursion-depth.c > > > @@ -24,8 +24,14 @@ > > > #include > > > #include > > > +#define FILENAME "/tmp/1" > > > +#define HASHBANG "#!" FILENAME "\n" > > > + > > > int main(void) > > > { > > > + char * const argv[] = { FILENAME, NULL }; > > > + int rv; > > > > Can we move out of -Wdeclaration-after-statement mentality in tests at least? > > selftest like the rest of the kernel follows the same coding guidelines. > It will follow the moving "-Wdeclaration-after-statement mentality" when > the rest of the kernel does. > > Looks like this topic was discussed in the following: > https://patchwork.kernel.org/project/linux-kbuild/patch/c6fda26e8d134264b04fadc3386d6c32@gmail.com/ The only real argument is "gcc miscompiles /proc" to which adding -Wdeclaration-after-statement looks like a too big hammer. Why can't we have nice things?