From: Yury Norov <yury.norov@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] iio: stmpe-adc: Use correctly sized arguments for bit field
Date: Thu, 3 Feb 2022 20:29:38 -0800 [thread overview]
Message-ID: <YfyrspBCYjH56xEU@yury-laptop> (raw)
In-Reply-To: <20211215232513.2070158-1-keescook@chromium.org>
On Wed, Dec 15, 2021 at 03:25:13PM -0800, Kees Cook wrote:
> The find.h APIs are designed to be used only on unsigned long arguments.
> This can technically result in a over-read, but it is harmless in this
> case. Regardless, fix it to avoid the warning seen under -Warray-bounds,
> which we'd like to enable globally:
>
> In file included from ./include/linux/bitmap.h:9,
> from ./include/linux/cpumask.h:12,
> from ./arch/x86/include/asm/cpumask.h:5,
> from ./arch/x86/include/asm/msr.h:11,
> from ./arch/x86/include/asm/processor.h:22,
> from ./arch/x86/include/asm/cpufeature.h:5,
> from ./arch/x86/include/asm/thread_info.h:53,
> from ./include/linux/thread_info.h:60,
> from ./arch/x86/include/asm/preempt.h:7,
> from ./include/linux/preempt.h:78,
> from ./include/linux/spinlock.h:55,
> from ./include/linux/swait.h:7,
> from ./include/linux/completion.h:12,
> from drivers/iio/adc/stmpe-adc.c:10:
> drivers/iio/adc/stmpe-adc.c: In function 'stmpe_adc_probe':
> ./include/linux/find.h:98:23: warning: array subscript 'long unsigned int[0]' is partly outside array bounds of 'u32[1]' {aka 'unsigned int[1]'} [-Warray-bounds]
> 98 | val = *addr | ~GENMASK(size - 1, offset);
> | ^~~~~
> drivers/iio/adc/stmpe-adc.c:258:13: note: while referencing 'norequest_mask'
> 258 | u32 norequest_mask = 0;
> | ^~~~~~~~~~~~~~
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> drivers/iio/adc/stmpe-adc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/stmpe-adc.c b/drivers/iio/adc/stmpe-adc.c
> index fba659bfdb40..d2d405388499 100644
> --- a/drivers/iio/adc/stmpe-adc.c
> +++ b/drivers/iio/adc/stmpe-adc.c
> @@ -256,6 +256,7 @@ static int stmpe_adc_probe(struct platform_device *pdev)
> struct stmpe_adc *info;
> struct device_node *np;
> u32 norequest_mask = 0;
> + unsigned long bits;
> int irq_temp, irq_adc;
> int num_chan = 0;
> int i = 0;
> @@ -309,8 +310,8 @@ static int stmpe_adc_probe(struct platform_device *pdev)
>
> of_property_read_u32(np, "st,norequest-mask", &norequest_mask);
>
> - for_each_clear_bit(i, (unsigned long *) &norequest_mask,
> - (STMPE_ADC_LAST_NR + 1)) {
> + bits = norequest_mask;
This would not work on 64-bit BE architecture. It should use bitmap_from_arr32()
> + for_each_clear_bit(i, &bits, (STMPE_ADC_LAST_NR + 1)) {
> stmpe_adc_voltage_chan(&info->stmpe_adc_iio_channels[num_chan], i);
> num_chan++;
> }
> --
> 2.30.2
next prev parent reply other threads:[~2022-02-04 4:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 23:25 [PATCH] iio: stmpe-adc: Use correctly sized arguments for bit field Kees Cook
2021-12-16 12:36 ` Jonathan Cameron
2022-02-04 4:29 ` Yury Norov [this message]
2022-02-05 13:38 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfyrspBCYjH56xEU@yury-laptop \
--to=yury.norov@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=jic23@kernel.org \
--cc=keescook@chromium.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).