From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0A55C433B4 for ; Mon, 17 May 2021 20:11:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3B1060E08 for ; Mon, 17 May 2021 20:11:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237755AbhEQUNL (ORCPT ); Mon, 17 May 2021 16:13:11 -0400 Received: from gateway24.websitewelcome.com ([192.185.50.45]:43839 "EHLO gateway24.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238503AbhEQUMk (ORCPT ); Mon, 17 May 2021 16:12:40 -0400 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 023FE6FA3 for ; Mon, 17 May 2021 15:11:21 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id ijYGlxv8AAEP6ijYGlaHLv; Mon, 17 May 2021 15:09:20 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:References:Cc:To:From:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=nNkGB/SMOVehPker/eeuybln3ISVaMpsQpy10U9fYN8=; b=OIDqYC1WeuePW1/YMttvu6mq1o tjzh7lKTt3baCQZH7Oh96AzHUhM2a6b+ERMwpJMivnV+wMd5a8P/zDui4b7rvb5u2mKWfzUvnWlCK X5EYUVkzsRvUd+8pe1/lNR2bNtUcZuDd279Q+e8eny/jCHNnm9bTti9a3nJWzvMdaAhlA0j/XhlHe gN2SI91KafFKqXTcNEYiO1PM1nzpi3if6RTJWsF+bcQKX4Gzkaq8zk+WyPjy2TqaRG/yyH4k83UQi dRHuCN7ORsFmjjsrXskk4CLh8BjWwb03x7hLrNKpwbVAR6HmLpIUs6kTZMfqYZy2mBFVtKDKtkSuC LCtLiXfg==; Received: from 187-162-31-110.static.axtel.net ([187.162.31.110]:52510 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1lijYC-0021s7-SL; Mon, 17 May 2021 15:09:16 -0500 Subject: Re: [PATCH RESEND][next] net: netrom: Fix fall-through warnings for Clang From: "Gustavo A. R. Silva" To: "Gustavo A. R. Silva" , Ralf Baechle , "David S. Miller" , Jakub Kicinski Cc: linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20210305092210.GA139864@embeddedor> <5047001a-e5a8-ec64-0dc7-662e7cb0d100@embeddedor.com> Message-ID: Date: Mon, 17 May 2021 15:09:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <5047001a-e5a8-ec64-0dc7-662e7cb0d100@embeddedor.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.31.110 X-Source-L: No X-Exim-ID: 1lijYC-0021s7-SL X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-31-110.static.axtel.net ([192.168.15.8]) [187.162.31.110]:52510 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 8 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org Hi Dave, I haven't received any feedback about these patches after resending them. We had thousands of these warnings and now we are down to less than a hundred in linux-next. I'm planning to take these patches in my -next tree for 5.14 as I'm planning to enable -Wimplicit-fallthrough for Clang for that release, too. Are you OK with this? Thanks -- Gustavo On 4/20/21 15:11, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? > > Thanks > -- > Gustavo > > On 3/5/21 03:22, Gustavo A. R. Silva wrote: >> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple >> warnings by explicitly adding multiple break statements instead of >> letting the code fall through to the next case. >> >> Link: https://github.com/KSPP/linux/issues/115 >> Signed-off-by: Gustavo A. R. Silva >> --- >> net/netrom/nr_route.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c >> index 78da5eab252a..de9821b6a62a 100644 >> --- a/net/netrom/nr_route.c >> +++ b/net/netrom/nr_route.c >> @@ -266,6 +266,7 @@ static int __must_check nr_add_node(ax25_address *nr, const char *mnemonic, >> fallthrough; >> case 2: >> re_sort_routes(nr_node, 0, 1); >> + break; >> case 1: >> break; >> } >> @@ -359,6 +360,7 @@ static int nr_del_node(ax25_address *callsign, ax25_address *neighbour, struct n >> fallthrough; >> case 1: >> nr_node->routes[1] = nr_node->routes[2]; >> + break; >> case 2: >> break; >> } >> @@ -482,6 +484,7 @@ static int nr_dec_obs(void) >> fallthrough; >> case 1: >> s->routes[1] = s->routes[2]; >> + break; >> case 2: >> break; >> } >> @@ -529,6 +532,7 @@ void nr_rt_device_down(struct net_device *dev) >> fallthrough; >> case 1: >> t->routes[1] = t->routes[2]; >> + break; >> case 2: >> break; >> } >>