From: Scott Branden <scott.branden@broadcom.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] misc: bcm-vk: Replace zero-length array with flexible array member
Date: Fri, 14 May 2021 16:26:02 -0700 [thread overview]
Message-ID: <ae9eb4fd-9109-6650-14bc-74fe71f42850@broadcom.com> (raw)
In-Reply-To: <20210514230801.GA35863@embeddedor>
[-- Attachment #1: Type: text/plain, Size: 1800 bytes --]
Looks fine to me.
On 2021-05-14 4:08 p.m., Gustavo A. R. Silva wrote:
> There is a regular need in the kernel to provide a way to declare
> having a dynamically sized set of trailing elements in a structure.
> Kernel code should always use “flexible array members”[1] for these
> cases. The older style of one-element or zero-length arrays should
> no longer be used[2].
>
> Also, make use of the struct_size() helper in kzalloc().
>
> [1] https://en.wikipedia.org/wiki/Flexible_array_member
> [2] https://www.kernel.org/doc/html/v5.10/process/deprecated.html#zero-length-and-one-element-arrays
>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> drivers/misc/bcm-vk/bcm_vk_msg.c | 3 +--
> drivers/misc/bcm-vk/bcm_vk_msg.h | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/bcm-vk/bcm_vk_msg.c b/drivers/misc/bcm-vk/bcm_vk_msg.c
> index f40cf08a6192..6efc52b49af6 100644
> --- a/drivers/misc/bcm-vk/bcm_vk_msg.c
> +++ b/drivers/misc/bcm-vk/bcm_vk_msg.c
> @@ -701,8 +701,7 @@ int bcm_vk_send_shutdown_msg(struct bcm_vk *vk, u32 shut_type,
> return -EINVAL;
> }
>
> - entry = kzalloc(sizeof(*entry) +
> - sizeof(struct vk_msg_blk), GFP_KERNEL);
> + entry = kzalloc(struct_size(entry, to_v_msg, 1), GFP_KERNEL);
> if (!entry)
> return -ENOMEM;
>
> diff --git a/drivers/misc/bcm-vk/bcm_vk_msg.h b/drivers/misc/bcm-vk/bcm_vk_msg.h
> index 4eaad84825d6..56784c8896d8 100644
> --- a/drivers/misc/bcm-vk/bcm_vk_msg.h
> +++ b/drivers/misc/bcm-vk/bcm_vk_msg.h
> @@ -116,7 +116,7 @@ struct bcm_vk_wkent {
> u32 usr_msg_id;
> u32 to_v_blks;
> u32 seq_num;
> - struct vk_msg_blk to_v_msg[0];
> + struct vk_msg_blk to_v_msg[];
> };
>
> /* queue stats counters */
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
prev parent reply other threads:[~2021-05-14 23:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 23:08 [PATCH][next] misc: bcm-vk: Replace zero-length array with flexible array member Gustavo A. R. Silva
2021-05-14 23:26 ` Scott Branden [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae9eb4fd-9109-6650-14bc-74fe71f42850@broadcom.com \
--to=scott.branden@broadcom.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).