From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0F63C433B4 for ; Tue, 20 Apr 2021 20:25:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88911613C2 for ; Tue, 20 Apr 2021 20:25:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233815AbhDTU0U (ORCPT ); Tue, 20 Apr 2021 16:26:20 -0400 Received: from gateway22.websitewelcome.com ([192.185.47.79]:21130 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233886AbhDTU0S (ORCPT ); Tue, 20 Apr 2021 16:26:18 -0400 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway22.websitewelcome.com (Postfix) with ESMTP id E4ED99C44 for ; Tue, 20 Apr 2021 15:25:38 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id YwwElQ0PgmJLsYwwEln0s1; Tue, 20 Apr 2021 15:25:38 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8WaJQOvWa34W2/gjggyjuGAo/HlnLHnW/HqDi/mf0Ak=; b=eNcKq1DbSrH6iad9NpTT715XoL UOHtRjGXWfBSB3vZTlFwpdFTYakeCFG3Z8gQnrL1ET4SKUjNX+EsHncYdkaBI8clEU05gYod2Ulmq 00fce/NgsxUK9VmqWZXPra54/8+xHSdDER5yHv64uzPH/rCOdR5fDoc4wPfzMfSwXErcW+9ZpOvBg 3FUKSjrXmv/2IhuxVH2OxW8MPI9unKaC2V1WehajcleSLqfcVHO6MqWFfjloI6Zo+xiplnhowAi6E fD8qdbyDo5mdnfEYSlzT7HislARTeHLTHNnSCXXjaqPJyR2XXxZcOPQcDtdL/PR+2UxqtzuWm94Y1 auTPDUNQ==; Received: from 187-162-31-110.static.axtel.net ([187.162.31.110]:49052 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lYwwB-0034SB-AG; Tue, 20 Apr 2021 15:25:35 -0500 Subject: Re: [PATCH 027/141] drbd: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" , Philipp Reisner , Lars Ellenberg , Jens Axboe Cc: drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <44663f18fb12e39c53b0e69039c98505b7c6d5da.1605896059.git.gustavoars@kernel.org> From: "Gustavo A. R. Silva" Message-ID: Date: Tue, 20 Apr 2021 15:25:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <44663f18fb12e39c53b0e69039c98505b7c6d5da.1605896059.git.gustavoars@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.31.110 X-Source-L: No X-Exim-ID: 1lYwwB-0034SB-AG X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-31-110.static.axtel.net ([192.168.15.8]) [187.162.31.110]:49052 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 185 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 11/20/20 12:28, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > of warnings by explicitly adding a break statement instead of just > letting the code fall through to the next, and by adding a fallthrough > pseudo-keyword in places whre the code is intended to fall through. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/block/drbd/drbd_receiver.c | 1 + > drivers/block/drbd/drbd_req.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c > index dc333dbe5232..c19bb74ac935 100644 > --- a/drivers/block/drbd/drbd_receiver.c > +++ b/drivers/block/drbd/drbd_receiver.c > @@ -5863,6 +5863,7 @@ static int got_NegRSDReply(struct drbd_connection *connection, struct packet_inf > switch (pi->cmd) { > case P_NEG_RS_DREPLY: > drbd_rs_failed_io(device, sector, size); > + break; > case P_RS_CANCEL: > break; > default: > diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c > index 330f851cb8f0..9f212a923a3c 100644 > --- a/drivers/block/drbd/drbd_req.c > +++ b/drivers/block/drbd/drbd_req.c > @@ -750,6 +750,7 @@ int __req_mod(struct drbd_request *req, enum drbd_req_event what, > > case WRITE_ACKED_BY_PEER_AND_SIS: > req->rq_state |= RQ_NET_SIS; > + fallthrough; > case WRITE_ACKED_BY_PEER: > /* Normal operation protocol C: successfully written on peer. > * During resync, even in protocol != C, >