From: Dan Li <ashimida@linux.alibaba.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: catalin.marinas@arm.com, will@kernel.org, nathan@kernel.org,
ndesaulniers@google.com, keescook@chromium.org,
masahiroy@kernel.org, tglx@linutronix.de,
akpm@linux-foundation.org, samitolvanen@google.com,
npiggin@gmail.com, linux@roeck-us.net, mhiramat@kernel.org,
ojeda@kernel.org, luc.vanoostenryck@gmail.com, elver@google.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] [PATCH] AARCH64: Add gcc Shadow Call Stack support
Date: Wed, 23 Feb 2022 01:06:01 -0800 [thread overview]
Message-ID: <c30e464f-6d61-1274-3c47-d0df5d98cada@linux.alibaba.com> (raw)
In-Reply-To: <YhUvp5RHkTlBXX3o@lakrids>
On 2/22/22 10:47, Mark Rutland wrote:
> Hi,
>
> On Tue, Feb 22, 2022 at 01:57:36AM -0800, Dan Li wrote:
>> Shadow call stack is available in GCC > 11.2.0, this patch makes
>> the corresponding kernel configuration available when compiling
>> the kernel with gcc.
>
> Neat!
>
> My local GCC devs told me that means GCC 12.x.x rather than 11.2.x or
> 11.3.x, so as others have said it'd be clearer to say `GCC >= 12.0.0`.
>
Ah, yes, I just saw this flag in gcc/BASE-VER.
> I'd like to try this with a GCC binary before I provide an Ack or R-b;
> but in the mean time I have a few comments below.
>
Thanks for your test, Mark.
Please let me know if there is any issues :)
>> ---
>> FYI:
>> This function can be used to test if the shadow call stack works:
>> //noinline void __noscs scs_test(void)
>> noinline void scs_test(void)
>> {
>> register unsigned long *sp asm("sp");
>> unsigned long * lr = sp + 1;
>>
>> asm volatile("":::"x30");
>> *lr = 0;
>> }
>
> It's probably be better to use __builtin_frame_address(0) to get the
> address of the frame record rather than assuming that fp==sp in the
> middle of the function.
>
Got it.
>> config SHADOW_CALL_STACK
>> - bool "Clang Shadow Call Stack"
>> - depends on CC_IS_CLANG && ARCH_SUPPORTS_SHADOW_CALL_STACK
>> + bool "Shadow Call Stack"
>> + depends on ARCH_SUPPORTS_SHADOW_CALL_STACK
>> depends on DYNAMIC_FTRACE_WITH_REGS || !FUNCTION_GRAPH_TRACER
>> help
>> - This option enables Clang's Shadow Call Stack, which uses a
>> + This option enables Clang/GCC's Shadow Call Stack, which uses a
>> shadow stack to protect function return addresses from being
>> overwritten by an attacker. More information can be found in
>> Clang's documentation:
>
> Is there any additional GCC documentation that we can refer to?
>
Currently there is only a brief description of
-fsanitize=shadow-call-stack in the user manual.
Since the description of the clang documentation is more detailed, should
I add this gcc link to the configuration description?
Link: https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html#Instrumentation-Options
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 09b885cc4db5..a48a604301aa 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -1255,7 +1255,7 @@ config HW_PERF_EVENTS
>> config ARCH_HAS_FILTER_PGPROT
>> def_bool y
>>
>> -# Supported by clang >= 7.0
>> +# Supported by clang >= 7.0 or GCC > 11.2.0
>
> As above, I beleive that should be `GCC >= 12.0.0`.
>
Yeah.
Thanks,
Dan.
next prev parent reply other threads:[~2022-02-23 9:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 9:57 [PATCH] [PATCH] AARCH64: Add gcc Shadow Call Stack support Dan Li
2022-02-22 16:16 ` Nathan Chancellor
2022-02-22 16:47 ` Guenter Roeck
2022-02-22 16:59 ` Miguel Ojeda
2022-02-23 8:58 ` Dan Li
2022-02-23 8:55 ` Dan Li
2022-02-23 8:50 ` Dan Li
2022-02-23 17:39 ` Nathan Chancellor
2022-02-25 0:34 ` Dan Li
2022-02-22 18:47 ` Mark Rutland
2022-02-23 9:06 ` Dan Li [this message]
2022-02-23 11:48 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c30e464f-6d61-1274-3c47-d0df5d98cada@linux.alibaba.com \
--to=ashimida@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=elver@google.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=llvm@lists.linux.dev \
--cc=luc.vanoostenryck@gmail.com \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mhiramat@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=npiggin@gmail.com \
--cc=ojeda@kernel.org \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).