linux-hexagon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Yan Zhao <yan.y.zhao@intel.com>
Cc: arnd@arndb.de, guoren@kernel.org, bcain@quicinc.com,
	jonas@southpole.se,  stefan.kristiansson@saunalahti.fi,
	shorne@gmail.com,  linux-arch@vger.kernel.org,
	linux-kernel@vger.kernel.org,  linux-csky@vger.kernel.org,
	linux-hexagon@vger.kernel.org,  linux-openrisc@vger.kernel.org
Subject: Re: [PATCH 0/4] apply page shift to PFN instead of VA in pfn_to_virt
Date: Wed, 31 Jan 2024 08:37:40 +0100	[thread overview]
Message-ID: <CACRpkdY6dS_sedemVk-fGzhsyT_B5dXAeFX-PO+GcvCrt9Je5w@mail.gmail.com> (raw)
In-Reply-To: <20240131055159.2506-1-yan.y.zhao@intel.com>

On Wed, Jan 31, 2024 at 7:25 AM Yan Zhao <yan.y.zhao@intel.com> wrote:

> This is a tiny fix to pfn_to_virt() for some platforms.
>
> The original implementaion of pfn_to_virt() takes PFN instead of PA as the
> input to macro __va, with PAGE_SHIFT applying to the converted VA, which
> is not right under most conditions, especially when there's an offset in
> __va.

Ooops that's right, I wonder why I got it wrong.
Arithmetic made it not regress :/
Thank you so much for fixing this Yan!

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Arnd: I think you can take most of them through the arch tree.

Yours,
Linus Walleij

  parent reply	other threads:[~2024-01-31  7:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31  5:51 [PATCH 0/4] apply page shift to PFN instead of VA in pfn_to_virt Yan Zhao
2024-01-31  5:57 ` [PATCH 1/4] asm-generic/page.h: " Yan Zhao
2024-02-23 11:26   ` Guo Ren
2024-02-29 13:34   ` Linus Walleij
2024-02-29 23:01     ` Yan Zhao
2024-01-31  5:59 ` [PATCH 2/4] csky: " Yan Zhao
2024-02-23 11:26   ` Guo Ren
2024-01-31  6:00 ` [PATCH 3/4] Hexagon: " Yan Zhao
2024-01-31  6:01 ` [PATCH 4/4] openrisc: " Yan Zhao
2024-01-31  7:37 ` Linus Walleij [this message]
2024-01-31 11:48 ` [PATCH 0/4] " Arnd Bergmann
2024-02-01  0:01   ` Yan Zhao
2024-02-01  5:46     ` Arnd Bergmann
2024-02-01 10:46       ` Geert Uytterhoeven
2024-02-02  7:27         ` Arnd Bergmann
2024-02-02  1:02       ` Yan Zhao
2024-02-02  7:04         ` Arnd Bergmann
2024-02-02 14:09           ` Yan Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdY6dS_sedemVk-fGzhsyT_B5dXAeFX-PO+GcvCrt9Je5w@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bcain@quicinc.com \
    --cc=guoren@kernel.org \
    --cc=jonas@southpole.se \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-hexagon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-openrisc@vger.kernel.org \
    --cc=shorne@gmail.com \
    --cc=stefan.kristiansson@saunalahti.fi \
    --cc=yan.y.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).