Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
From: Eddie James <eajames@linux.ibm.com>
To: Joel Stanley <joel@jms.id.au>
Cc: linux-hwmon@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] hwmon (occ): Fix license headers
Date: Mon, 21 Jan 2019 15:15:29 -0600
Message-ID: <0566a8cf-b9f3-617a-712e-95c92cf8af70@linux.ibm.com> (raw)
In-Reply-To: <CACPK8XeRgCRmyFFxrwCGKnBm=+o=m_L6G=ZWftOV_QB7ATjxow@mail.gmail.com>



On 01/21/2019 02:19 PM, Joel Stanley wrote:
> On Tue, 22 Jan 2019 at 06:56, Eddie James <eajames@linux.ibm.com> wrote:
>
>> --- a/drivers/hwmon/occ/common.h
>> +++ b/drivers/hwmon/occ/common.h
>> @@ -1,4 +1,5 @@
>> -/* SPDX-License-Identifier: GPL-2.0 */
>> +// SPDX-License-Identifier: GPL-2.0+
>> +// Copyright IBM Corp 2019
> We want to use the /* */ syntax for headers. Take a closer look at
> Documentation/process/license-rules.rst:

Oops. Do I put the copyright in the copyright in the same comment block 
then? Or use // for that?

>
> 2. Style:
>
>     The SPDX license identifier is added in form of a comment.  The comment
>     style depends on the file type::
>
>        C source: // SPDX-License-Identifier: <SPDX License Expression>
>        C header: /* SPDX-License-Identifier: <SPDX License Expression> */
>


  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21 19:56 [PATCH 0/2] occ: FSI and hwmon: " Eddie James
2019-01-21 19:56 ` [PATCH 1/2] hwmon (occ): " Eddie James
2019-01-21 20:19   ` Joel Stanley
2019-01-21 21:15     ` Eddie James [this message]
2019-01-22  0:40       ` Guenter Roeck
2019-01-21 19:56 ` [PATCH 2/2] fsi: occ: Fix license header Eddie James

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0566a8cf-b9f3-617a-712e-95c92cf8af70@linux.ibm.com \
    --to=eajames@linux.ibm.com \
    --cc=jdelvare@suse.com \
    --cc=joel@jms.id.au \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org linux-hwmon@archiver.kernel.org
	public-inbox-index linux-hwmon


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/ public-inbox