From: Robin Murphy <robin.murphy@arm.com>
To: arnd@arndb.de, olof@lixom.net
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
linux@roeck-us.net, jdelvare@suse.com, kgene@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
thierry.reding@gmail.com, jonathanh@nvidia.com, heiko@sntech.de,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties
Date: Wed, 27 Mar 2019 16:17:30 +0000 [thread overview]
Message-ID: <14a24871-f22d-a500-8f49-922d0374ddca@arm.com> (raw)
In-Reply-To: <CAJKOXPd12YPvL61nu0TDWze4pBuQK=KbJCrc5wh-tACsRQt37g@mail.gmail.com>
[ +Arnd, Olof ]
On 19/03/2019 15:06, Krzysztof Kozlowski wrote:
> On Tue, 19 Mar 2019 at 15:54, Robin Murphy <robin.murphy@arm.com> wrote:
>>
>> The old "cooling-{min,max}-state" properties for thermal bindings were
>> ratified to "cooling-{min,max}-level" by commit eb168b70dea5 ("of:
>> thermal: Fix inconsitency between cooling-*-state and cooling-*-level"),
>> which were later removed entirely by commit e04907dbc259 ("dt-bindings:
>> thermal: Remove "cooling-{min|max}-level" properties").
>>
>> The pwm-fan binding, however, was apparently in-flight in parallel with
>> that ratification, and so managed to introduce an example of the old
>> properties which escaped the scope of the later cleanup and has thus
>> continued to be dutifully copied for new boards despite being useless.
>> Clean up these remaining undocumented anachronisms to minimise any
>> further confusion.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>> ---
>>
>> Presented as one big hwmon patch for simplicity, but the DT changes
>> can quite easily be broken out by platform if maintainers prefer.
>>
>> Robin.
>>
>> Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 2 --
>> arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 --
>> arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 --
>> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 --
>
> Probably you should send it directly to arm-soc maintainers so it
> would go with other DT changes. In such case:
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Indeed, it had crossed my mind that routing this through arm-soc might
make sense - Arnd, Olof, would you agree? And if so, should I resend to
the arm-soc alias or might you be able to pick it directly?
Thanks to everyone for the acks!
Robin.
>
> Best regards,
> Krzysztof
>
>> arch/arm/boot/dts/imx6qdl-emcon.dtsi | 2 --
>> arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 2 --
>> arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi | 2 --
>> arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 2 --
>> 8 files changed, 16 deletions(-)
>>
next prev parent reply other threads:[~2019-03-27 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 14:54 [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties Robin Murphy
2019-03-19 15:00 ` Guenter Roeck
2019-03-19 15:06 ` Krzysztof Kozlowski
2019-03-27 16:17 ` Robin Murphy [this message]
2019-03-19 15:14 ` Thierry Reding
2019-03-19 15:27 ` Heiko Stübner
2019-03-22 0:46 ` Shawn Guo
2019-03-31 6:40 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14a24871-f22d-a500-8f49-922d0374ddca@arm.com \
--to=robin.murphy@arm.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jdelvare@suse.com \
--cc=jonathanh@nvidia.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=olof@lixom.net \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).