From: Tim Harvey <tharvey@gateworks.com>
To: Lee Jones <lee.jones@linaro.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-hwmon@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Robert Jones <rjones@gateworks.com>
Cc: Tim Harvey <tharvey@gateworks.com>
Subject: [PATCH v6 1/3] dt-bindings: mfd: Add Gateworks System Controller bindings
Date: Tue, 17 Mar 2020 10:00:51 -0700 [thread overview]
Message-ID: <1584464453-28200-2-git-send-email-tharvey@gateworks.com> (raw)
In-Reply-To: <1584464453-28200-1-git-send-email-tharvey@gateworks.com>
This patch adds documentation of device-tree bindings for the
Gateworks System Controller (GSC).
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
v6:
- fix commit message typo
- drop invalid description from #interrupt-cells property
- fix adc pattern property
- add unit suffix
- replace hwmon/adc with adc/channel
- changed adc type to gw,mode
- add unit suffix and drop ref for voltage-divider
- add unit suffix for voltage-offset
- moved fan to its own subnode with base register
v5:
- resolve dt_binding_check issues
v4:
- move to using pwm<n>_auto_point<m>_{pwm,temp} for FAN PWM
- remove unncessary resolution/scaling properties for ADCs
- update to yaml
- remove watchdog
v3:
- replaced _ with -
- remove input bindings
- added full description of hwmon
- fix unit address of hwmon child nodes
---
.../devicetree/bindings/mfd/gateworks-gsc.yaml | 172 +++++++++++++++++++++
1 file changed, 172 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
new file mode 100644
index 00000000..e921e67
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
@@ -0,0 +1,172 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/gateworks-gsc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Gateworks System Controller multi-function device
+
+description: |
+ The GSC is a Multifunction I2C slave device with the following submodules:
+ - Watchdog Timer
+ - GPIO
+ - Pushbutton controller
+ - Hardware Monitor with ADC's for temperature and voltage rails and
+ fan controller
+
+maintainers:
+ - Tim Harvey <tharvey@gateworks.com>
+ - Robert Jones <rjones@gateworks.com>
+
+properties:
+ $nodename:
+ pattern: "gsc@[0-9a-f]{1,2}"
+ compatible:
+ const: gw,gsc
+
+ reg:
+ description: I2C device address
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 1
+
+ adc:
+ type: object
+ description: Optional Hardware Monitoring module
+
+ properties:
+ compatible:
+ const: gw,gsc-adc
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+ patternProperties:
+ "^channel@[0-9]+$":
+ type: object
+ description: |
+ Properties for a single ADC which can report cooked values
+ (ie temperature sensor based on thermister), raw values
+ (ie voltage rail with a pre-scaling resistor divider).
+
+ properties:
+ reg:
+ description: Register of the ADC
+ maxItems: 1
+
+ label:
+ description: Name of the ADC input
+
+ gw,mode:
+ description: |
+ conversion mode:
+ 0 - temperature, in C*10
+ 1 - pre-scaled voltage value
+ 2 - scaled voltage based on an optional resistor divider
+ and optional offset
+ allOf:
+ - $ref: /schemas/types.yaml#/definitions/uint32
+ enum: [0, 1, 2]
+
+ gw,voltage-divider-milli-ohms:
+ description: values of resistors for divider on raw ADC input
+ items:
+ - description: R1
+ - description: R2
+
+ gw,voltage-offset-microvolt:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ A positive voltage offset to apply to a raw ADC
+ (ie to compensate for a diode drop).
+
+ required:
+ - gw,mode
+ - reg
+ - label
+
+ required:
+ - compatible
+ - "#address-cells"
+ - "#size-cells"
+
+ fan:
+ type: object
+ description: Optional FAN controller
+
+ properties:
+ compatible:
+ const: gw,gsc-fan
+
+ base:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: The fan controller base address
+ maxItems: 1
+
+ required:
+ - compatible
+ - base
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - interrupt-controller
+ - "#interrupt-cells"
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ gsc@20 {
+ compatible = "gw,gsc";
+ reg = <0x20>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <4 GPIO_ACTIVE_LOW>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ adc {
+ compatible = "gw,gsc-adc";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ channel@0 { /* A0: Board Temperature */
+ gw,mode = <0>;
+ reg = <0x00>;
+ label = "temp";
+ };
+
+ channel@2 { /* A1: Input Voltage (raw ADC) */
+ gw,mode = <1>;
+ reg = <0x02>;
+ label = "vdd_vin";
+ gw,voltage-divider-milli-ohms = <22100 1000>;
+ gw,voltage-offset-microvolt = <800000>;
+ };
+
+ channel@b { /* A2: Battery voltage */
+ gw,mode = <1>;
+ reg = <0x0b>;
+ label = "vdd_bat";
+ };
+ };
+
+ fan {
+ compatible = "gw,gsc-fan";
+ base = <0x2c>;
+ };
+ };
+ };
--
2.7.4
next prev parent reply other threads:[~2020-03-17 17:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 17:00 [PATCH v6 0/3] Add support for the Gateworks System Controller Tim Harvey
2020-03-17 17:00 ` Tim Harvey [this message]
2020-03-20 3:15 ` [PATCH v6 1/3] dt-bindings: mfd: Add Gateworks System Controller bindings Rob Herring
2020-03-17 17:00 ` [PATCH v6 2/3] mfd: add Gateworks System Controller core driver Tim Harvey
2020-03-17 17:00 ` [PATCH v6 3/3] hwmon: add Gateworks System Controller support Tim Harvey
2020-03-17 17:03 ` Randy Dunlap
2020-03-17 17:07 ` Tim Harvey
2020-03-17 17:18 ` Guenter Roeck
2020-03-17 17:44 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1584464453-28200-2-git-send-email-tharvey@gateworks.com \
--to=tharvey@gateworks.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rjones@gateworks.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).