Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
From: "Sa, Nuno" <Nuno.Sa@analog.com>
To: "linux@roeck-us.net" <linux@roeck-us.net>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
	"mdf@kernel.org" <mdf@kernel.org>,
	"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"jdelvare@suse.com" <jdelvare@suse.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH 2/3] hwmon: Support ADI Fan Control IP
Date: Wed, 9 Oct 2019 07:10:29 +0000
Message-ID: <1d064ffa4eb0698121eca4862ee4d25e2140e333.camel@analog.com> (raw)
In-Reply-To: <20191008201129.GA14652@roeck-us.net>

On Tue, 2019-10-08 at 13:11 -0700, Guenter Roeck wrote:
> 
> On Tue, Oct 08, 2019 at 03:59:49PM +0000, Sa, Nuno wrote:
> [ ... ]
> > > > +
> > > > +	ctl->irq = platform_get_irq(pdev, 0);
> > > > +	if (ctl->irq < 0) {
> > > 
> > > This can return -EPROBE_DEFER. On top of that, it already
> > > generates
> > > an error
> > > message, meaning another one here is unnecessary.
> > 
> > Why returning -EPROBE_DEFER? platform_get_irq() already seems to
> > handle
> > EPROBE_DEFER...
> > 
> ... which is exactly why I am saying that you don't need another
> error
> message, and that an unconditional error message is a bad idea.
> 

Ahhh, sorry. I completely misunderstood you :(

Nuno Sá

> Guenter


  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-26 10:39 [PATCH 0/3] Support AXI FAN Control IP core Nuno Sá
2019-09-26 10:39 ` [PATCH 1/3] include: fpga: adi-axi-common: Define version macros Nuno Sá
2019-09-27 15:01   ` Moritz Fischer
2019-09-30 10:46     ` Sa, Nuno
2019-09-26 10:39 ` [PATCH 2/3] hwmon: Support ADI Fan Control IP Nuno Sá
2019-10-06 15:32   ` Guenter Roeck
2019-10-07 13:52     ` Sa, Nuno
2019-10-07 14:18       ` Guenter Roeck
2019-10-07 15:08         ` Sa, Nuno
2019-10-08 15:59     ` Sa, Nuno
2019-10-08 20:11       ` Guenter Roeck
2019-10-09  7:10         ` Sa, Nuno [this message]
2019-09-26 10:39 ` [PATCH 3/3] dt-bindings: hwmon: Add AXI FAN Control documentation Nuno Sá

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d064ffa4eb0698121eca4862ee4d25e2140e333.camel@analog.com \
    --to=nuno.sa@analog.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=mdf@kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org linux-hwmon@archiver.kernel.org
	public-inbox-index linux-hwmon

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/ public-inbox