linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon (lm63) Do not overwrite data->kind
Date: Tue, 13 Nov 2018 09:12:49 -0800	[thread overview]
Message-ID: <20181113171249.GA21521@roeck-us.net> (raw)

On Mon, Nov 12, 2018 at 08:36:56PM -0800, Nicolin Chen wrote:
> According to the code right before the removed line, data->kind
> should be either from DT or from id pointer. So there shouldn't
> be an additional overwriting after the if-else statement.
> 
> So this patch just removes the overwriting line.
> 
> Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> ---
> Guenter,
>     I have not really tested this change but still sent it out
>     since it looks obvious. Please feel free to drop it if you
>     have concern at an untested change. Thanks.

Good find. You are right, the patch introducing the DT code didn't
really do anything. Given that no one (including me) noticed that
commit b25f663b91f1a was effectively a no-op, I'll queue this up
for the next kernel release.

Thanks,
Guenter

> 
>  drivers/hwmon/lm63.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwmon/lm63.c b/drivers/hwmon/lm63.c
> index 4c1770920d29..eac54b9cdeec 100644
> --- a/drivers/hwmon/lm63.c
> +++ b/drivers/hwmon/lm63.c
> @@ -1120,7 +1120,6 @@ static int lm63_probe(struct i2c_client *client,
>  		data->kind = (enum chips)of_device_get_match_data(&client->dev);
>  	else
>  		data->kind = id->driver_data;
> -	data->kind = id->driver_data;
>  	if (data->kind == lm64)
>  		data->temp2_offset = 16000;
>  
> -- 
> 2.17.1
> 

             reply	other threads:[~2018-11-14  3:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13 17:12 Guenter Roeck [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-11-13  4:36 [PATCH] hwmon (lm63) Do not overwrite data->kind Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181113171249.GA21521@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicoleotsuka@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).