From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f193.google.com ([209.85.215.193]:46180 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728175AbeKQC2R (ORCPT ); Fri, 16 Nov 2018 21:28:17 -0500 Received: by mail-pg1-f193.google.com with SMTP id w7so10787558pgp.13 for ; Fri, 16 Nov 2018 08:15:17 -0800 (PST) Date: Fri, 16 Nov 2018 08:15:15 -0800 From: Guenter Roeck To: Vadim Pasternak Cc: linux-hwmon@vger.kernel.org, michaelsh@mellanox.com Subject: Re: [PATCH hwmon-next v1 1/1] hwmon: (mlxreg-fan) Fix macros for tacho fault reading Message-ID: <20181116161515.GA30440@roeck-us.net> References: <1542376031-179816-1-git-send-email-vadimp@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1542376031-179816-1-git-send-email-vadimp@mellanox.com> Sender: linux-hwmon-owner@vger.kernel.org List-Id: linux-hwmon@vger.kernel.org On Fri, Nov 16, 2018 at 01:47:11PM +0000, Vadim Pasternak wrote: > Fix macros for tacometer fault reading. > This fix is relevant for three Mellanox systems MQMB7, MSN37, MSN34, > which are about to be released to the customers. > At the moment, none of them is at customers sites. > > Fixes: 65afb4c8e7e4 ("hwmon: (mlxreg-fan) Add support for Mellanox FAN driver") > Signed-off-by: Vadim Pasternak > --- > drivers/hwmon/mlxreg-fan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/mlxreg-fan.c b/drivers/hwmon/mlxreg-fan.c > index de46577..d8fa4be 100644 > --- a/drivers/hwmon/mlxreg-fan.c > +++ b/drivers/hwmon/mlxreg-fan.c > @@ -51,7 +51,7 @@ > */ > #define MLXREG_FAN_GET_RPM(rval, d, s) (DIV_ROUND_CLOSEST(15000000 * 100, \ > ((rval) + (s)) * (d))) > -#define MLXREG_FAN_GET_FAULT(val, mask) (!!((val) ^ (mask))) > +#define MLXREG_FAN_GET_FAULT(val, mask) (!((val) ^ (mask))) You might want to check if the "^" is correct here. It looks fishy, since the expression only evaluates to true if a no bit of val outside mask is set. I would have expected "&". Guenter > #define MLXREG_FAN_PWM_DUTY2STATE(duty) (DIV_ROUND_CLOSEST((duty) * \ > MLXREG_FAN_MAX_STATE, \ > MLXREG_FAN_MAX_DUTY))