From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com ([209.85.128.65]:37698 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727829AbeK1X5w (ORCPT ); Wed, 28 Nov 2018 18:57:52 -0500 Received: by mail-wm1-f65.google.com with SMTP id g67so2475168wmd.2 for ; Wed, 28 Nov 2018 04:56:16 -0800 (PST) Date: Wed, 28 Nov 2018 13:56:13 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Michele Sorcinelli Cc: Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org Subject: Re: [PATCH] dell-smm-hwmon.c: Add XPS 9570 to supported devices list Message-ID: <20181128125613.7sblicuf6xqd7lun@pali> References: <20181127230637.8673-1-michelesr@autistici.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-hwmon-owner@vger.kernel.org List-Id: linux-hwmon@vger.kernel.org On Wednesday 28 November 2018 12:30:31 Michele Sorcinelli wrote: > The output of sensors related to the is: > > dell_smm-virtual-0 > Adapter: Virtual device > fan1: 0 RPM > fan2: 0 RPM Ok, this means that both fans are turned off. When you start fans, have both number meaningful/correct value? > This suggests that temperature sensors are not discovered. Yes, probably they are unsupported or not discovered. But this is not a problem. > Speeds reported in the hwmon interface are consistent with the others. > > > On 11/27/18 11:06 PM, Michele Sorcinelli wrote: > > Allow the module to be loaded on Dell XPS 9570, without having to use > > the "force=1" option. The module loads without problems, and reports > > correct fan values: > > > > $ time cat /proc/i8k > > 1.0 1.5 -1 35 0 0 0 0 -1 -22 > > cat /proc/i8k 0.00s user 0.00s system 7% cpu 0.033 total > > > > However, the call may freeze the kernel for a very small time due to > > code running in the SSM layer. This is a known issue with the driver, and > > can be reproduced with other supported models. Average execution > > time is 33 ms. > > > > The command line tools from i8kutils can properly set the fan speed, > > although the firmware will override it, unless automatic fan > > control is disabled with the proper SSM call. > > > > Average fans speed (when firwmare automatic control is off): > > > > STATE -> RPM > > 0 0 -> 0 0 > > 1 1 -> 2500 2500 > > 2 2 -> 5100 5100 > > 3 3 -> same as 2 2 > > --- > > drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c > > index 9d3ef879d..367a8a617 100644 > > --- a/drivers/hwmon/dell-smm-hwmon.c > > +++ b/drivers/hwmon/dell-smm-hwmon.c > > @@ -1017,6 +1017,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = { > > DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9560"), > > }, > > }, > > + { > > + .ident = "Dell XPS 15 9570", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > > + DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9570"), > > + }, > > + }, > > { } > > }; > > -- Pali Rohár pali.rohar@gmail.com