From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E72C0C07EBF for ; Fri, 18 Jan 2019 18:55:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9C8820823 for ; Fri, 18 Jan 2019 18:55:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k6ZrlkZk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728946AbfARSzL (ORCPT ); Fri, 18 Jan 2019 13:55:11 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:39176 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728863AbfARSzL (ORCPT ); Fri, 18 Jan 2019 13:55:11 -0500 Received: by mail-pg1-f194.google.com with SMTP id w6so6465765pgl.6 for ; Fri, 18 Jan 2019 10:55:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ZMnm4+AOkTLV4MTaJ30SICnRO9y2FqsFEcISqoEZeP4=; b=k6ZrlkZktn0NuTAlvTn5LjCyDi7W/j/ZNvS1rNvojR0rq8/OaGE2eq4WQVu6wsDdLp L1pDs6UiU+GTBVKoxHiQ8EsJLUhhdAgOCsP6oz+8YdLfgvjhmX8gPcOvIsogdrMDT7q0 /Htx+auUcw76uT8lweoNxAPIRUogAn2upm/hdwr8JW7YvduzS5uU2z6+y1icEFWt0Mv8 3+xE7S57mGazgZjTJaNZEP+fZEJhDIKbbwoBc64VZZuF9FSMvRAF4H0tZU2vgOTQnjtN 8ShY5CHC5XpYdLTUxjF9UJCaBpq2+5Tdekm6eQRGC18MRoEhsz5QSAetjHpvvOoVoxxq VGpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=ZMnm4+AOkTLV4MTaJ30SICnRO9y2FqsFEcISqoEZeP4=; b=YcJDckBgtFJ7jMAJCDl81Jc5IzyD8dPNt+cO5ygXCaEb1MQ0eaG2QCSFlKfLF3XVba jD+3TdnhovmjrMaC4E4QWfBl1Yh3uy0lvU3ZI6Xpb6dR+C9W2DtJBNewCYdVyRRt360r QXiDoVsN4aOAaX9khqLZdTk37K5ToV0M3y3/AM7YyQajtgwz9kPw5sLYGClSPS6qdmrb DlYbU6oQsjuesWWIseAso09Ayyle8Hdt/Hyi/aYCK2iVeAtKtLLMiXlTMWHSx/cL9vWH jfilGrNvEwYAf6cg27WNbBNwWqt3P7LL2qSorYhl8MOny7ceQPlllT9o21JKTrxruMBI a02A== X-Gm-Message-State: AJcUukcw4McU8b4wr2iDpH0Z7tJdd0ZqE6Uh5r3GvQEzI/v0vMCqCdhi 55Ddeqm9gT+74xXA+IWbBcs= X-Google-Smtp-Source: ALg8bN6oXyiiisOwGanWDRoKXl9DVU9vZQOjE0oyKAKOmH9Z5A6wSif5VFgqpY+iipmwUQrSNLUrnQ== X-Received: by 2002:a63:9e19:: with SMTP id s25mr18871453pgd.203.1547837710053; Fri, 18 Jan 2019 10:55:10 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id p6sm7835840pfn.53.2019.01.18.10.55.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 10:55:08 -0800 (PST) Date: Fri, 18 Jan 2019 10:55:06 -0800 From: Guenter Roeck To: Liviu Dudau Cc: Hardware Monitoring , Jean Delvare , Sudeep Holla , Lorenzo Pieralisi Subject: Re: [PATCH 29/30] hwmon: (vexpress-hwmon) Use permission specific SENSOR[_DEVICE]_ATTR variants Message-ID: <20190118185506.GA5284@roeck-us.net> References: <1547831700-15865-1-git-send-email-linux@roeck-us.net> <1547831700-15865-30-git-send-email-linux@roeck-us.net> <20190118182212.GJ20661@e110455-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190118182212.GJ20661@e110455-lin.cambridge.arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Fri, Jan 18, 2019 at 06:22:12PM +0000, Liviu Dudau wrote: > On Fri, Jan 18, 2019 at 09:14:59AM -0800, Guenter Roeck wrote: > > Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code, > > to improve readbility, and to reduce the chance of inconsistencies. > > > > Also replace any remaining S_ in the driver with octal values. > > > > The conversion was done automatically with coccinelle. The semantic patches > > and the scripts used to generate this commit log are available at > > https://github.com/groeck/coccinelle-patches/hwmon/. > > > > This patch does not introduce functional changes. It was verified by > > compiling the old and new files and comparing text and data sizes. > > > > Cc: Liviu Dudau > > Cc: Sudeep Holla > > Cc: Lorenzo Pieralisi > > Signed-off-by: Guenter Roeck > > Acked-by: Liviu Dudau > > Are you going to take the patch via your tree? > Yes. Thanks, Guenter > Best regards, > Liviu > > > --- > > drivers/hwmon/vexpress-hwmon.c | 25 ++++++++++--------------- > > 1 file changed, 10 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/hwmon/vexpress-hwmon.c b/drivers/hwmon/vexpress-hwmon.c > > index 8ba419d343f8..0b84adb5e88e 100644 > > --- a/drivers/hwmon/vexpress-hwmon.c > > +++ b/drivers/hwmon/vexpress-hwmon.c > > @@ -92,9 +92,8 @@ struct vexpress_hwmon_type { > > }; > > > > #if !defined(CONFIG_REGULATOR_VEXPRESS) > > -static DEVICE_ATTR(in1_label, S_IRUGO, vexpress_hwmon_label_show, NULL); > > -static SENSOR_DEVICE_ATTR(in1_input, S_IRUGO, vexpress_hwmon_u32_show, > > - NULL, 1000); > > +static DEVICE_ATTR(in1_label, 0444, vexpress_hwmon_label_show, NULL); > > +static SENSOR_DEVICE_ATTR_RO(in1_input, vexpress_hwmon_u32, 1000); > > static struct attribute *vexpress_hwmon_attrs_volt[] = { > > &dev_attr_in1_label.attr, > > &sensor_dev_attr_in1_input.dev_attr.attr, > > @@ -113,9 +112,8 @@ static struct vexpress_hwmon_type vexpress_hwmon_volt = { > > }; > > #endif > > > > -static DEVICE_ATTR(curr1_label, S_IRUGO, vexpress_hwmon_label_show, NULL); > > -static SENSOR_DEVICE_ATTR(curr1_input, S_IRUGO, vexpress_hwmon_u32_show, > > - NULL, 1000); > > +static DEVICE_ATTR(curr1_label, 0444, vexpress_hwmon_label_show, NULL); > > +static SENSOR_DEVICE_ATTR_RO(curr1_input, vexpress_hwmon_u32, 1000); > > static struct attribute *vexpress_hwmon_attrs_amp[] = { > > &dev_attr_curr1_label.attr, > > &sensor_dev_attr_curr1_input.dev_attr.attr, > > @@ -133,9 +131,8 @@ static struct vexpress_hwmon_type vexpress_hwmon_amp = { > > }, > > }; > > > > -static DEVICE_ATTR(temp1_label, S_IRUGO, vexpress_hwmon_label_show, NULL); > > -static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, vexpress_hwmon_u32_show, > > - NULL, 1000); > > +static DEVICE_ATTR(temp1_label, 0444, vexpress_hwmon_label_show, NULL); > > +static SENSOR_DEVICE_ATTR_RO(temp1_input, vexpress_hwmon_u32, 1000); > > static struct attribute *vexpress_hwmon_attrs_temp[] = { > > &dev_attr_temp1_label.attr, > > &sensor_dev_attr_temp1_input.dev_attr.attr, > > @@ -153,9 +150,8 @@ static struct vexpress_hwmon_type vexpress_hwmon_temp = { > > }, > > }; > > > > -static DEVICE_ATTR(power1_label, S_IRUGO, vexpress_hwmon_label_show, NULL); > > -static SENSOR_DEVICE_ATTR(power1_input, S_IRUGO, vexpress_hwmon_u32_show, > > - NULL, 1); > > +static DEVICE_ATTR(power1_label, 0444, vexpress_hwmon_label_show, NULL); > > +static SENSOR_DEVICE_ATTR_RO(power1_input, vexpress_hwmon_u32, 1); > > static struct attribute *vexpress_hwmon_attrs_power[] = { > > &dev_attr_power1_label.attr, > > &sensor_dev_attr_power1_input.dev_attr.attr, > > @@ -173,9 +169,8 @@ static struct vexpress_hwmon_type vexpress_hwmon_power = { > > }, > > }; > > > > -static DEVICE_ATTR(energy1_label, S_IRUGO, vexpress_hwmon_label_show, NULL); > > -static SENSOR_DEVICE_ATTR(energy1_input, S_IRUGO, vexpress_hwmon_u64_show, > > - NULL, 1); > > +static DEVICE_ATTR(energy1_label, 0444, vexpress_hwmon_label_show, NULL); > > +static SENSOR_DEVICE_ATTR_RO(energy1_input, vexpress_hwmon_u64, 1); > > static struct attribute *vexpress_hwmon_attrs_energy[] = { > > &dev_attr_energy1_label.attr, > > &sensor_dev_attr_energy1_input.dev_attr.attr, > > -- > > 2.7.4 > > > > -- > ==================== > | I would like to | > | fix the world, | > | but they're not | > | giving me the | > \ source code! / > --------------- > ¯\_(ツ)_/¯