* [PATCH] dt-bindings: hwmon: Add lm75 documentation
@ 2019-01-29 6:56 Jagan Teki
2019-01-31 18:06 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Jagan Teki @ 2019-01-29 6:56 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Rob Herring, Mark Rutland
Cc: linux-hwmon, devicetree, linux-kernel, linux-amarula, Jagan Teki
Add dt-binding documentation for lm75 hwmon sensor.
Currently documented for national,lm75 and st,stlm75 and
rest might add when required.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Documentation/devicetree/bindings/hwmon/lm75.txt | 15 +++++++++++++++
1 file changed, 15 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt
diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt b/Documentation/devicetree/bindings/hwmon/lm75.txt
new file mode 100644
index 000000000000..e384a3765f10
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/lm75.txt
@@ -0,0 +1,15 @@
+*LM75 hwmon sensor.
+
+Required properties:
+- compatible: one of
+ "national,lm75"
+ "st,stlm75"
+
+- reg: I2C address
+
+Example:
+
+sensor@48 {
+ compatible = "st,stlm75";
+ reg = <0x48>;
+};
--
2.18.0.321.gffc6fa0e3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: hwmon: Add lm75 documentation
2019-01-29 6:56 [PATCH] dt-bindings: hwmon: Add lm75 documentation Jagan Teki
@ 2019-01-31 18:06 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2019-01-31 18:06 UTC (permalink / raw)
To: Jagan Teki
Cc: Jean Delvare, Rob Herring, Mark Rutland, linux-hwmon, devicetree,
linux-kernel, linux-amarula
On Tue, Jan 29, 2019 at 12:26:23PM +0530, Jagan Teki wrote:
> Add dt-binding documentation for lm75 hwmon sensor.
>
> Currently documented for national,lm75 and st,stlm75 and
> rest might add when required.
Why ? The various properties are already implemented in the driver.
I don't see the value documenting only two of them.
I do see though that nxp,lm75, and nxp,lm75a are used but _not_
referenced in the driver.
If we start cleaning that up I think it would make more sense
to clean up everything, not just part of it.
Thanks,
Guenter
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Documentation/devicetree/bindings/hwmon/lm75.txt | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt b/Documentation/devicetree/bindings/hwmon/lm75.txt
> new file mode 100644
> index 000000000000..e384a3765f10
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/lm75.txt
> @@ -0,0 +1,15 @@
> +*LM75 hwmon sensor.
> +
> +Required properties:
> +- compatible: one of
> + "national,lm75"
> + "st,stlm75"
> +
> +- reg: I2C address
> +
> +Example:
> +
> +sensor@48 {
> + compatible = "st,stlm75";
> + reg = <0x48>;
> +};
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-31 18:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 6:56 [PATCH] dt-bindings: hwmon: Add lm75 documentation Jagan Teki
2019-01-31 18:06 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).