From: Guenter Roeck <linux@roeck-us.net>
To: Matt Wilbur <wilburm@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 1/1] Fix swapped coeffs for LM5066 and LM5066i iin
Date: Thu, 31 Jan 2019 10:11:43 -0800 [thread overview]
Message-ID: <20190131181143.GA17285@roeck-us.net> (raw)
In-Reply-To: <20190128170034.24348-2-wilburm@gmail.com>
Hi,
On Mon, Jan 28, 2019 at 12:00:34PM -0500, Matt Wilbur wrote:
> ---
Unfortunately, your patch is not signed, and I can not apply it.
Also, the explanation should be part of this patch. Please
also note the expected subject line, which should start with
"hwmon: (pmbus/lm25066)".
On top of that, while the subject claims to also address LM5066i,
it does not really do that.
Guenter
> drivers/hwmon/pmbus/lm25066.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/lm25066.c b/drivers/hwmon/pmbus/lm25066.c
> index 53db78753a0d..9d917b5f0a81 100644
> --- a/drivers/hwmon/pmbus/lm25066.c
> +++ b/drivers/hwmon/pmbus/lm25066.c
> @@ -156,11 +156,11 @@ static struct __coeff lm25066_coeff[6][PSC_NUM_CLASSES + 2] = {
> .R = -2,
> },
> [PSC_CURRENT_IN] = {
> - .m = 10753,
> + .m = 5405,
> .R = -2,
> },
> [PSC_CURRENT_IN_L] = {
> - .m = 5405,
> + .m = 10753,
> .R = -2,
> },
> [PSC_POWER] = {
> @@ -197,13 +197,13 @@ static struct __coeff lm25066_coeff[6][PSC_NUM_CLASSES + 2] = {
> .R = -2,
> },
> [PSC_POWER] = {
> - .m = 1701,
> - .b = -4000,
> + .m = 861,
> + .b = -965,
> .R = -3,
> },
> [PSC_POWER_L] = {
> - .m = 861,
> - .b = -965,
> + .m = 1701,
> + .b = -4000,
> .R = -3,
> },
> [PSC_TEMPERATURE] = {
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-01-31 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 17:00 [PATCH 0/1] Fix swapped coeffs for LM5066 and LM5066i iin Matt Wilbur
2019-01-28 17:00 ` [PATCH 1/1] " Matt Wilbur
2019-01-31 18:11 ` Guenter Roeck [this message]
2019-02-01 11:41 ` Matt Wilbur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131181143.GA17285@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=wilburm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).