From: Guenter Roeck <linux@roeck-us.net>
To: Jeremy Gebben <jgebben@sweptlaser.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] hwmon: (lm85) add support for LM96000 high frequencies
Date: Fri, 1 Feb 2019 14:37:46 -0800 [thread overview]
Message-ID: <20190201223746.GA16166@roeck-us.net> (raw)
In-Reply-To: <20190131220617.15223-4-jgebben@sweptlaser.com>
On Thu, Jan 31, 2019 at 03:06:17PM -0700, Jeremy Gebben wrote:
> This chip expands the freqency field from 3 to 4 bits, to
> add more frequencies in the 22.5 to 30 kHz ranges.
>
"This chip" -> LM96000
> Signed-off-by: Jeremy Gebben <jgebben@sweptlaser.com>
> ---
> Documentation/hwmon/lm85 | 3 +++
> drivers/hwmon/lm85.c | 9 +++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/Documentation/hwmon/lm85 b/Documentation/hwmon/lm85
> index 9f3a945d1..264874f09 100644
> --- a/Documentation/hwmon/lm85
> +++ b/Documentation/hwmon/lm85
> @@ -140,6 +140,9 @@ of voltage and temperature channels.
> SMSC EMC6D103S is similar to EMC6D103, but does not support pwm#_auto_pwm_minctl
> and temp#_auto_temp_off.
>
> +The LM96000 supports additional high frequency PWM modes (22.5 kHz, 24 kHz,
> +25.7 kHz, 27.7 kHz and 30 kHz), which can be configured on a per-PWM basis.
> +
> Hardware Configurations
> -----------------------
>
> diff --git a/drivers/hwmon/lm85.c b/drivers/hwmon/lm85.c
> index 4b15193d1..88f08f4bc 100644
> --- a/drivers/hwmon/lm85.c
> +++ b/drivers/hwmon/lm85.c
> @@ -202,6 +202,11 @@ static const int lm85_freq_map[] = { /* 1 Hz */
> 10, 15, 23, 30, 38, 47, 61, 94
> };
>
> +static const int lm85_high_freq_map[] = { /* 1 Hz */
> + 10, 15, 23, 30, 38, 47, 61, 94,
> + 22500, 24000, 25700, 25700, 27700, 27700, 30000, 30000
> +};
Should be lm96000_freq_map.
> +
> static const int adm1027_freq_map[] = { /* 1 Hz */
> 11, 15, 22, 29, 35, 44, 59, 88
> };
> @@ -1574,6 +1579,10 @@ static int lm85_probe(struct i2c_client *client, const struct i2c_device_id *id)
> data->freq_map = adm1027_freq_map;
> data->freq_map_size = ARRAY_SIZE(adm1027_freq_map);
> break;
> + case lm85:
> + data->freq_map = lm85_high_freq_map;
> + data->freq_map_size = ARRAY_SIZE(lm85_high_freq_map);
> + break;
This is too generic. You'll have to introduce a 'lm96000' type
and use it. That should be straightforward since the lm96000
is already detected (and for some reason handled as lm85).
> default:
> data->freq_map = lm85_freq_map;
> data->freq_map_size = ARRAY_SIZE(lm85_freq_map);
> --
> 2.17.1
>
prev parent reply other threads:[~2019-02-01 22:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 22:06 [PATCH v2 0/3] hwmon: (lm85) add LM96000 high freqency pwm support Jeremy Gebben
2019-01-31 22:06 ` [PATCH v2 1/3] hwmon: (lm85) remove freq_map size hardcodes Jeremy Gebben
2019-01-31 22:06 ` [PATCH v2 2/3] hwmon: (lm85) Document the LM96000 as supported Jeremy Gebben
2019-01-31 22:06 ` [PATCH v2 3/3] hwmon: (lm85) add support for LM96000 high frequencies Jeremy Gebben
2019-02-01 22:37 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201223746.GA16166@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=jgebben@sweptlaser.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).