Linux-Hwmon Archive on lore.kernel.org
 help / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: hwmon: Add missing documentation for lm75
Date: Thu, 28 Feb 2019 09:15:43 -0600
Message-ID: <20190228151543.GA18597@bogus> (raw)
In-Reply-To: <20190212113808.3040-1-jagan@amarulasolutions.com>

On Tue, Feb 12, 2019 at 05:08:08PM +0530, Jagan Teki wrote:
> Add missing dt-binding documentation for lm75 hwmon sensor.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> -  Add all compatible nodes available in lm75.
> 
>  .../devicetree/bindings/hwmon/lm75.txt        | 37 +++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt b/Documentation/devicetree/bindings/hwmon/lm75.txt
> new file mode 100644
> index 000000000000..12d8cf7cf592
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/lm75.txt
> @@ -0,0 +1,37 @@
> +*LM75 hwmon sensor.
> +
> +Required properties:
> +- compatible: manufacturer and chip name, one of
> +		"adi,adt75",
> +		"dallas,ds1775",
> +		"dallas,ds75",
> +		"dallas,ds7505",
> +		"gmt,g751",
> +		"national,lm75",
> +		"national,lm75a",
> +		"national,lm75b",
> +		"maxim,max6625",
> +		"maxim,max6626",
> +		"maxim,max31725",
> +		"maxim,max31726",
> +		"maxim,mcp980x",
> +		"st,stds75",
> +		"st,stlm75",
> +		"microchip,tcn75",
> +		"ti,tmp100",
> +		"ti,tmp101",
> +		"ti,tmp105",
> +		"ti,tmp112",
> +		"ti,tmp175",
> +		"ti,tmp275",
> +		"ti,tmp75",
> +		"ti,tmp75c",

Some of these are in trivial-devices.yaml already. So you either need to 
remove them from there. Or you can move all these to trivial-devices and 
benefit from having a schema. I prefer the latter, but either way is 
fine. You can remove them from trivial-devices.yaml in a separate patch, 
so:

Acked-by: Rob Herring <robh@kernel.org>

Rob

P.S. Third option is convert this doc to DT schema. Don't tell anyone, 
but you'll be a the top of my review queue.

  parent reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-12 11:38 Jagan Teki
2019-02-20 17:22 ` Jagan Teki
2019-02-21 14:02   ` Guenter Roeck
2019-02-26  6:04     ` Jagan Teki
2019-02-28 15:15 ` Rob Herring [this message]
2019-02-28 17:30   ` Jagan Teki
2019-02-28 17:39     ` Guenter Roeck

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190228151543.GA18597@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jagan@amarulasolutions.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org linux-hwmon@archiver.kernel.org
	public-inbox-index linux-hwmon


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/ public-inbox