From: Guenter Roeck <linux@roeck-us.net>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
jdelvare@suse.com, andrew@aj.id.au, mine260309@gmail.com
Subject: Re: [PATCH 1/3] hwmon (occ): Store error condition for rate-limited polls
Date: Tue, 16 Apr 2019 15:12:31 -0700 [thread overview]
Message-ID: <20190416221231.GA31987@roeck-us.net> (raw)
In-Reply-To: <1555429430-23118-1-git-send-email-eajames@linux.ibm.com>
On Tue, Apr 16, 2019 at 03:43:48PM +0000, Eddie James wrote:
> The OCC driver limits the rate of sending poll commands to the OCC. If a
> user reads a hwmon entry after a poll response resulted in an error and
> is rate-limited, the error is invisible to the user. Fix this by storing
> the last error and returning that in the rate-limited case.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/occ/common.c | 4 ++++
> drivers/hwmon/occ/common.h | 3 ++-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/occ/common.c b/drivers/hwmon/occ/common.c
> index 9d197e9..13a6290 100644
> --- a/drivers/hwmon/occ/common.c
> +++ b/drivers/hwmon/occ/common.c
> @@ -141,6 +141,7 @@ static int occ_poll(struct occ *occ)
> /* mutex should already be locked if necessary */
> rc = occ->send_cmd(occ, cmd);
> if (rc) {
> + occ->last_error = rc;
> if (occ->error_count++ > OCC_ERROR_COUNT_THRESHOLD)
> occ->error = rc;
>
> @@ -149,6 +150,7 @@ static int occ_poll(struct occ *occ)
>
> /* clear error since communication was successful */
> occ->error_count = 0;
> + occ->last_error = 0;
> occ->error = 0;
>
> /* check for safe state */
> @@ -210,6 +212,8 @@ int occ_update_response(struct occ *occ)
> if (time_after(jiffies, occ->last_update + OCC_UPDATE_FREQUENCY)) {
> rc = occ_poll(occ);
> occ->last_update = jiffies;
> + } else {
> + rc = occ->last_error;
> }
>
> mutex_unlock(&occ->lock);
> diff --git a/drivers/hwmon/occ/common.h b/drivers/hwmon/occ/common.h
> index ed2cf42..fc13f3c 100644
> --- a/drivers/hwmon/occ/common.h
> +++ b/drivers/hwmon/occ/common.h
> @@ -106,7 +106,8 @@ struct occ {
> struct attribute_group group;
> const struct attribute_group *groups[2];
>
> - int error; /* latest transfer error */
> + int error; /* final transfer error after retry */
> + int last_error; /* latest transfer error */
> unsigned int error_count; /* number of xfr errors observed */
> unsigned long last_safe; /* time OCC entered "safe" state */
>
prev parent reply other threads:[~2019-04-16 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 15:43 [PATCH 1/3] hwmon (occ): Store error condition for rate-limited polls Eddie James
2019-04-16 15:43 ` [PATCH 2/3] hwmon (occ): Prevent sysfs error attribute from returning error Eddie James
2019-04-16 22:14 ` Guenter Roeck
2019-04-16 15:43 ` [PATCH 3/3] hwmon (occ): Add more details to Kconfig help text Eddie James
2019-04-16 22:15 ` Guenter Roeck
2019-04-16 22:12 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416221231.GA31987@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mine260309@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).