From: Guenter Roeck <linux@roeck-us.net>
To: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Cc: linux-hwmon@vger.kernel.org, jdelvare@suse.com
Subject: Re: [PATCH v3] hwmon: max6650: add thermal cooling device capability
Date: Thu, 18 Apr 2019 13:55:35 -0700 [thread overview]
Message-ID: <20190418205535.GB13496@roeck-us.net> (raw)
In-Reply-To: <386CEABE-23A4-4BB6-968A-738B8D84DE4E@gmail.com>
On Thu, Apr 18, 2019 at 04:45:00PM -0400, Jean-Francois Dagenais wrote:
>
> > On Apr 18, 2019, at 16:13, Guenter Roeck <linux@roeck-us.net> wrote:
> >
> >> + if (IS_ERR(data->cooling_dev)) {
> >> + err = PTR_ERR(data->cooling_dev);
> >> + dev_err(&client->dev,
> >> + "Failed to register as cooling device (%d)\n", err);
> >
> > As mentioned in my other mail, this message adds zero value. Please drop.
>
> How does one distinguish the different failures which can occur within a probe
> function then. I know it is only useful for system integrators while debugging
> DTS for example. But I find my self always having to insert these kind of messages
> at each "return" statements of a failing probe implementation. I just think it's
> nice for developers which can use the info to quickly troubleshoot the problem.
>
> I won't fight this though. You are maintainer of this subsys so...
>
Yes, I know there are peple who like a lot of messages. I don't - it happend
to me too often that the actual important message(s) get lost in the noise.
Anyway, see below.
> >
> >> + return err;
> >
> > Sorry, I won't accept this.
>
> You mean, you won't accept v3, but a v4 without the dev_err?
>
I won't accept v3 due to the error return, which may be considered a
regression for those who don't care about using the driver with the
thermal subsystem.
If you insist on an extra message, I'll accept a dev_warn.
> Perhaps also, we should wait a v4 which would use your new devm_register... ?
Your call, but there is no guarantee that this series will ever be
accepted. The thermal maintainers may object to the new devm function.
Guenter
next prev parent reply other threads:[~2019-04-18 20:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 16:48 [PATCH v2] hwmon: max6650: add thermal cooling device capability Jean-Francois Dagenais
2019-04-18 17:38 ` Guenter Roeck
2019-04-18 18:02 ` Jean-Francois Dagenais
2019-04-18 18:06 ` Guenter Roeck
2019-04-18 19:54 ` Jean-Francois Dagenais
2019-04-18 20:04 ` [PATCH v3] " Jean-Francois Dagenais
2019-04-18 20:13 ` Guenter Roeck
2019-04-18 20:45 ` Jean-Francois Dagenais
2019-04-18 20:55 ` Guenter Roeck [this message]
2019-04-18 20:12 ` [PATCH v2] " Guenter Roeck
2019-04-18 20:39 ` Jean-Francois Dagenais
2019-04-18 20:50 ` Guenter Roeck
2019-04-18 21:33 ` Jean-Francois Dagenais
2019-04-18 22:02 ` Guenter Roeck
2019-04-19 0:57 ` [PATCH v4] " Jean-Francois Dagenais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418205535.GB13496@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=jeff.dagenais@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).