From: Chen Rong <rong.a.chen@intel.com>
To: LKP Developer <lkp-developer@eclists.intel.com>,
Philip Li <philip.li@intel.com>
Cc: Chen Rong <rong.a.chen@intel.com>,
Julia Lawall <julia.lawall@lip6.fr>,
kbuild-all@01.org, linux-hwmon@vger.kernel.org
Subject: [PATCH 0day-kernel-tests] lib/kbuild.sh: fix no reported-by for volunteers
Date: Wed, 24 Apr 2019 10:05:42 +0800 [thread overview]
Message-ID: <20190424020542.30921-1-rong.a.chen@intel.com> (raw)
-------------
Date: Wed, 24 Apr 2019 03:38:39 +0800
From: kbuild test robot <lkp@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: [hwmon:hwmon-playground 130/134] drivers/hwmon/max6650.c:632:4-10: preceding lock on line 616
CC: kbuild-all@01.org
CC: linux-hwmon@vger.kernel.org
TO: Guenter Roeck <linux@roeck-us.net>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-playground
head: 05d763050bbaa40daa4b60a3912c9311ca5791a5
commit: 77d270a1d4db919db0b02fec1d85ad5a57d556d7 [130/134] hwmon: (max6650) Convert to use devm_hwmon_device_register_with_info
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
>> drivers/hwmon/max6650.c:632:4-10: preceding lock on line 616
-------------
Signed-off-by: Chen Rong <rong.a.chen@intel.com>
---
lib/kbuild.sh | 38 ++++++++++++++++++++++----------------
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git a/lib/kbuild.sh b/lib/kbuild.sh
index e48fa079..4cb89104 100755
--- a/lib/kbuild.sh
+++ b/lib/kbuild.sh
@@ -6324,7 +6324,14 @@ add_cc_volunteer()
local mail_address=$1
echo "CC: $mail_address"
- REPORTED_BY+="Reported-by: $mail_address\n"
+ REPORTED_BY+="Reported-by: $mail_address"$'\n'
+}
+
+email_reported_by_suggestion()
+{
+ echo "If you fix the issue, kindly add following tag"
+ echo "Reported-by: kbuild test robot <lkp@intel.com>"
+ echo "$REPORTED_BY"
}
email_header()
@@ -7782,14 +7789,13 @@ send_email()
cat > $email_file <<EOF
Message-ID: $message_id
$(email_subject)
-$(email_header)
-
-$(email_commit_info)
-
-If you fix the issue, kindly add following tag
-Reported-by: kbuild test robot <lkp@intel.com>
-$(echo -e $REPORTED_BY)
-
+$(
+email_header;
+echo "";
+email_commit_info;
+echo "";
+email_reported_by_suggestion
+)
$(email_errors)
$(email_signature)
@@ -9284,13 +9290,13 @@ email_checkpatch()
LANG=en_US.UTF8 mailx -S sendmail=$C_ROOT/sendmail -t <<EOF
$(email_subject)
-$(email_header)
-
-$(email_commit_info)
-
-If you fix the issue, kindly add following tag
-Reported-by: kbuild test robot <lkp@intel.com>
-
+$(
+email_header;
+echo "";
+email_commit_info;
+echo "";
+email_reported_by_suggestion
+)
scripts/checkpatch.pl $(basename $patch)
# many are suggestions rather than must-fix
--
2.17.1
reply other threads:[~2019-04-24 2:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424020542.30921-1-rong.a.chen@intel.com \
--to=rong.a.chen@intel.com \
--cc=julia.lawall@lip6.fr \
--cc=kbuild-all@01.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=lkp-developer@eclists.intel.com \
--cc=philip.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).