From: Guenter Roeck <linux@roeck-us.net>
To: Iker Perez del Palomar <iker.perez@codethink.co.uk>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
jdelvare@suse.com
Subject: Re: Fwd: [PATCH 1/2] hwmon: (lm75) Add support for TMP75B
Date: Wed, 24 Apr 2019 10:37:35 -0700 [thread overview]
Message-ID: <20190424173735.GB29860@roeck-us.net> (raw)
In-Reply-To: <e3d0b580-5552-fc4c-7ecc-660b000bfbc4@codethink.co.uk>
On Wed, Apr 24, 2019 at 03:10:38PM +0100, Iker Perez del Palomar wrote:
> Hi,
>
>
> Thank you for the review, I will submitted fixed soon. I have one question
> before doing it though, after running scrips/chechpatch.sh I obtain the next
> message:
>
> WARNING: DT compatible string "ti,tmp75b" appears un-documented -- check ./Documentation/devicetree/bindings/
> #83: FILE: drivers/hwmon/lm75.c:549:
> + .compatible = "ti,tmp75b",
>
> total: 0 errors, 1 warnings, 60 lines checked
>
> So I added the next in
> "Documentation/devicetree/bindings/trivial-devices.yaml":
>
> - ti,amc6821
> # I2C Touch-Screen Controller
> - ti,tsc2003
> + # Digital Temperature Sensor with Two-Wire Interface and Alert
> + - ti,tmp75b
> # Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
> - ti,tmp102
> # Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
>
>
> Is that the proper procedure??
It would make more sense to add it to
Documentation/devicetree/bindings/hwmon/lm75.txt
since this is where most of the lm75 compatible chips are listed.
Thanks,
Guenter
prev parent reply other threads:[~2019-04-24 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2904a750-c6e9-719b-7523-0f45e0bc82cc@codethink.co.uk>
2019-04-23 10:11 ` Fwd: [PATCH 1/2] hwmon: (lm75) Add support for TMP75B Iker Perez del Palomar
2019-04-23 13:52 ` Guenter Roeck
2019-04-24 14:54 ` Iker Perez del Palomar
[not found] ` <e3d0b580-5552-fc4c-7ecc-660b000bfbc4@codethink.co.uk>
2019-04-24 17:37 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424173735.GB29860@roeck-us.net \
--to=linux@roeck-us.net \
--cc=iker.perez@codethink.co.uk \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).